Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation
Patch Set: Fixed lifetime Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 9c82e152d7ca74a9ad767d4eee7fe35f28bbe0f6..6269cd9a580b8eebca4ab8b07d659bd44a6d104f 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -89,10 +89,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
// construction and so we pass it in here.
static BrowserPluginGuest* Create(
int instance_id,
- SiteInstance* guest_site_instance,
WebContentsImpl* web_contents,
- scoped_ptr<base::DictionaryValue> extra_params,
- BrowserPluginGuest* opener);
+ BrowserPluginGuestDelegate* delegate);
// Returns whether the given WebContents is a BrowserPlugin guest.
static bool IsGuest(WebContentsImpl* web_contents);
@@ -114,6 +112,8 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
// this BrowserPluginGuest, and its new unattached windows.
void Destroy();
+ WebContentsImpl* CreateNewGuestWindow(WebContents::CreateParams* params);
lazyboy 2014/06/17 23:46:46 I'd add a note that |params| could be modified. Al
Fady Samuel 2014/06/18 21:08:34 Done.
+
// Returns the identifier that uniquely identifies a browser plugin guest
// within an embedder.
int instance_id() const { return instance_id_; }
@@ -132,9 +132,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
bool visible() const { return guest_visible_; }
bool is_in_destruction() { return is_in_destruction_; }
- // Returns the BrowserPluginGuest that created this guest, if any.
- BrowserPluginGuest* GetOpener() const;
-
void UpdateVisibility();
void CopyFromCompositingSurface(

Powered by Google App Engine
This is Rietveld 408576698