chrome/renderer/resources/extensions/web_view.js - Issue 336283002: Remove GuestWebContentsCreated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 336283002: Remove GuestWebContentsCreated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_creation

Patch Set: Merge with ToT Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index 81b5d3fd4a2d13daf3d7a6c14f508b56c0a8e0be..f3abbecead89809cd28721ded96306106e605bb8 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -612,9 +612,16 @@ WebViewInternal.prototype.hasGuestInstanceID = function() {

};

WebViewInternal.prototype.allocateInstanceId = function() {

- // Parse .src and .partition.

+ var storagePartitionId =

+ this.webviewNode.getAttribute(WEB_VIEW_ATTRIBUTE_PARTITION) ||

+ this.webviewNode[WEB_VIEW_ATTRIBUTE_PARTITION];

+ var params = {

+ 'storagePartitionId': storagePartitionId,

+ };

var self = this;

- GuestViewInternal.allocateInstanceId(

+ GuestViewInternal.createGuest(

+ 'webview',

+ params,

function(instanceId) {

self.instanceId = instanceId;

// TODO(lazyboy): Make sure this.autoNavigate_ stuff correctly updated