Remove GuestWebContentsCreated

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 807 matching lines @@
   // safe to continue.
   CHECK(can_be_default || !partition_domain->empty());
 }
 
 content::WebContentsViewDelegate*
     ChromeContentBrowserClient::GetWebContentsViewDelegate(
         content::WebContents* web_contents) {
   return chrome::CreateWebContentsViewDelegate(web_contents);
 }
 
-void ChromeContentBrowserClient::GuestWebContentsCreated(

[lazyboy, 2014/06/17 23:46:45]

After GuestWebContentsAttached() gets/got removed, you can clean up lots of
#includes now.

[Fady Samuel, 2014/06/18 21:08:33]

We still refer to GuestView* and WebViewGuest in this class, so i don't think I
can remove anything.

-    int guest_instance_id,
-    SiteInstance* guest_site_instance,
-    WebContents* guest_web_contents,
-    WebContents* opener_web_contents,
-    content::BrowserPluginGuestDelegate** guest_delegate,
-    scoped_ptr<base::DictionaryValue> extra_params) {
-#if defined(ENABLE_EXTENSIONS)
-  if (!guest_site_instance) {
-    NOTREACHED();
-    return;
-  }
-  GURL guest_site_url = guest_site_instance->GetSiteURL();
-  const std::string& extension_id = guest_site_url.host();
-
-  Profile* profile = Profile::FromBrowserContext(
-      guest_web_contents->GetBrowserContext());
-  ExtensionService* service =
-      extensions::ExtensionSystem::Get(profile)->extension_service();
-  if (!service) {
-    NOTREACHED();
-    return;
-  }
-
-  /// TODO(fsamuel): In the future, certain types of GuestViewBases won't
-  // require extension bindings. At that point, we should clear |extension_id|
-  // instead of exiting early.
-  if (!extension_id.empty() &&
-      !service->GetExtensionById(extension_id, false)) {
-    NOTREACHED();
-    return;
-  }
-
-  if (opener_web_contents) {
-    GuestViewBase* guest = GuestViewBase::FromWebContents(opener_web_contents);
-    DCHECK(guest);
-
-    // Create a new GuestViewBase of the same type as the opener.
-    *guest_delegate = GuestViewBase::Create(
-        guest_instance_id,
-        guest_web_contents,
-        extension_id,
-        guest->GetViewType());
-    return;
-  }
-
-  if (!extra_params) {
-    NOTREACHED();
-    return;
-  }
-  std::string api_type;
-  extra_params->GetString(guestview::kParameterApi, &api_type);
-
-  if (api_type.empty())
-    return;
-
-  *guest_delegate =
-      GuestViewBase::Create(guest_instance_id,
-                            guest_web_contents,
-                            extension_id,
-                            api_type);
-#else
-  NOTREACHED();
-#endif  // defined(ENABLE_EXTENSIONS)
-}
-
 void ChromeContentBrowserClient::RenderProcessWillLaunch(
     content::RenderProcessHost* host) {
   int id = host->GetID();
   Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
   net::URLRequestContextGetter* context =
       profile->GetRequestContextForRenderProcess(id);
 
   host->AddFilter(new ChromeRenderMessageFilter(id, profile));
 #if defined(ENABLE_EXTENSIONS)
   host->AddFilter(new ChromeExtensionMessageFilter(id, profile));
@@ skipping 1925 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome