content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_adview

Patch Set: Hopefully fixed tests Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 42f8f95fecf66711db69f519644aefb820de5801..30b47890802068aae42b6a698f0e063a8459f3ca 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -136,18 +136,8 @@ void BrowserPluginEmbedder::OnGuestCallback(

: NULL;

}

- if (guest) {

- // There is an implicit order expectation here:

- // 1. The content embedder is made aware of the attachment.

- // 2. BrowserPluginGuest::Attach is called.

- // 3. The content embedder issues queued events if any that happened

- // prior to attachment.

- GetContentClient()->browser()->GuestWebContentsAttached(

- guest->GetWebContents(),

- GetWebContents(),

- *extra_params);

+ if (guest)

guest->Attach(GetWebContents(), params, *extra_params);

- }

}

void BrowserPluginEmbedder::OnAttach(

« no previous file with comments | « chrome/chrome_browser.gypi ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »