Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1502)

Unified Diff: chrome/browser/guest_view/guest_view_manager.cc

Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_adview
Patch Set: Hopefully fixed tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/guest_view_manager.cc
diff --git a/chrome/browser/guest_view/guest_view_manager.cc b/chrome/browser/guest_view/guest_view_manager.cc
index 39c0ceaaaaae79ee4b85a57eebbcf7026518c5eb..981b4ac598614749d0f6704e8e14a652d20d4875 100644
--- a/chrome/browser/guest_view/guest_view_manager.cc
+++ b/chrome/browser/guest_view/guest_view_manager.cc
@@ -8,6 +8,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/guest_view/guest_view_base.h"
#include "chrome/browser/guest_view/guest_view_constants.h"
+#include "chrome/browser/guest_view/guest_view_manager_factory.h"
#include "chrome/browser/guest_view/web_view/web_view_guest.h"
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/browser_context.h"
@@ -24,6 +25,9 @@ using content::BrowserContext;
using content::SiteInstance;
using content::WebContents;
+// static
+GuestViewManagerFactory* GuestViewManager::factory_ = NULL;
+
GuestViewManager::GuestViewManager(content::BrowserContext* context)
: current_instance_id_(0), last_instance_id_removed_(0), context_(context) {
}
@@ -37,7 +41,11 @@ GuestViewManager* GuestViewManager::FromBrowserContext(
static_cast<GuestViewManager*>(context->GetUserData(
guestview::kGuestViewManagerKeyName));
if (!guest_manager) {
- guest_manager = new GuestViewManager(context);
+ if (factory_) {
+ guest_manager = factory_->CreateGuestViewManager(context);
+ } else {
+ guest_manager = new GuestViewManager(context);
+ }
context->SetUserData(guestview::kGuestViewManagerKeyName, guest_manager);
}
return guest_manager;
« no previous file with comments | « chrome/browser/guest_view/guest_view_manager.h ('k') | chrome/browser/guest_view/guest_view_manager_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698