Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: extensions/browser/extension_test_registry_observer.h

Issue 334083002: Add a test helper class for ExtensionRegistry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ben's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_test_registry_observer.h
diff --git a/extensions/browser/extension_test_registry_observer.h b/extensions/browser/extension_test_registry_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..178236c4849713a2f3ac743a9f56cdc5a7cc1346
--- /dev/null
+++ b/extensions/browser/extension_test_registry_observer.h
@@ -0,0 +1,48 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_EXTENSION_TEST_REGISTRY_OBSERVER_H_
+#define EXTENSIONS_BROWSER_EXTENSION_TEST_REGISTRY_OBSERVER_H_
+
+#include "base/scoped_observer.h"
+#include "content/public/test/test_utils.h"
+#include "extensions/browser/extension_registry_observer.h"
+
+namespace extensions {
+class ExtensionRegistry;
+
+// A helper class that listen for ExtensionRegistry notifications.
+class ExtensionTestRegistryObserver : public ExtensionRegistryObserver {
Yoyo Zhou 2014/06/17 02:29:54 nit: TestExtensionRegistryObserver?
limasdf 2014/06/17 17:20:55 Done.
+ public:
+ explicit ExtensionTestRegistryObserver(ExtensionRegistry* registry);
+ virtual ~ExtensionTestRegistryObserver();
+
+ void WaitForAnyExtensionWillBeInstalled();
Yoyo Zhou 2014/06/17 02:29:54 These should be documented. What do you think of c
limasdf 2014/06/17 17:20:55 Done.
+ void WaitForAnyExtensionUninstalled();
+
+ private:
+ class Waiter;
+
+ // ExtensionRegistryObserver.
+ virtual void OnExtensionWillBeInstalled(
+ content::BrowserContext* browser_context,
+ const Extension* extension,
+ bool is_update,
+ bool from_ephemeral,
+ const std::string& old_name) OVERRIDE;
+ virtual void OnExtensionUninstalled(content::BrowserContext* browser_context,
+ const Extension* extension) OVERRIDE;
+
+ scoped_ptr<Waiter> installed_waiter_;
Yoyo Zhou 2014/06/17 02:29:54 should be will_be_uninstalled_ for consistency.
limasdf 2014/06/17 17:20:56 Done.
+ scoped_ptr<Waiter> uninstalled_waiter_;
+
+ ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
+ extension_registry_observer_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionTestRegistryObserver);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_BROWSER_EXTENSION_TEST_REGISTRY_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698