Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: content/common/sandbox_linux/bpf_utility_policy_linux.cc

Issue 333823002: Apply renderer sandbox to utility processes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to jln feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/sandbox_linux/bpf_renderer_policy_linux.h" 5 #include "content/common/sandbox_linux/bpf_utility_policy_linux.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
11 #include "content/common/sandbox_linux/sandbox_linux.h" 11 #include "content/common/sandbox_linux/sandbox_linux.h"
12 #include "sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h" 12 #include "sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h"
13 #include "sandbox/linux/seccomp-bpf-helpers/syscall_sets.h" 13 #include "sandbox/linux/seccomp-bpf-helpers/syscall_sets.h"
14 #include "sandbox/linux/seccomp-bpf/sandbox_bpf_policy.h" 14 #include "sandbox/linux/seccomp-bpf/sandbox_bpf_policy.h"
15 #include "sandbox/linux/services/linux_syscalls.h" 15 #include "sandbox/linux/services/linux_syscalls.h"
16 16
17 using sandbox::SyscallSets; 17 using sandbox::SyscallSets;
18 18
19 namespace content { 19 namespace content {
20 20
21 RendererProcessPolicy::RendererProcessPolicy() {} 21 UtilityProcessPolicy::UtilityProcessPolicy() {
22 RendererProcessPolicy::~RendererProcessPolicy() {} 22 }
23 UtilityProcessPolicy::~UtilityProcessPolicy() {
24 }
23 25
24 ErrorCode RendererProcessPolicy::EvaluateSyscall(SandboxBPF* sandbox, 26 ErrorCode UtilityProcessPolicy::EvaluateSyscall(SandboxBPF* sandbox,
25 int sysno) const { 27 int sysno) const {
28 // TODO(mdempsky): See if we can limit these further.
jln (very slow on Chromium) 2014/06/25 00:28:08 Let's mention explicitly that this is a fork of th
mdempsky 2014/06/25 00:43:30 Done.
26 switch (sysno) { 29 switch (sysno) {
27 case __NR_ioctl: 30 case __NR_ioctl:
28 return sandbox::RestrictIoctl(sandbox); 31 return sandbox::RestrictIoctl(sandbox);
29 // Allow the system calls below. 32 // Allow the system calls below.
30 // The baseline policy allows __NR_clock_gettime. Allow 33 // The baseline policy allows __NR_clock_gettime. Allow
31 // clock_getres() for V8. crbug.com/329053. 34 // clock_getres() for V8. crbug.com/329053.
jln (very slow on Chromium) 2014/06/25 00:28:08 FYI: All the exceptions that have been added late
mdempsky 2014/06/25 00:43:30 Yep, was planning on tackling that in a followup.
32 case __NR_clock_getres: 35 case __NR_clock_getres:
33 case __NR_fdatasync: 36 case __NR_fdatasync:
34 case __NR_fsync: 37 case __NR_fsync:
35 case __NR_getpriority: 38 case __NR_getpriority:
36 #if defined(__i386__) || defined(__x86_64__) 39 #if defined(__i386__) || defined(__x86_64__)
37 case __NR_getrlimit: 40 case __NR_getrlimit:
38 #endif 41 #endif
39 #if defined(__i386__) || defined(__arm__) 42 #if defined(__i386__) || defined(__arm__)
40 case __NR_ugetrlimit: 43 case __NR_ugetrlimit:
41 #endif 44 #endif
(...skipping 13 matching lines...) Expand all
55 return ErrorCode(ErrorCode::ERR_ALLOWED); 58 return ErrorCode(ErrorCode::ERR_ALLOWED);
56 case __NR_prlimit64: 59 case __NR_prlimit64:
57 return ErrorCode(EPERM); // See crbug.com/160157. 60 return ErrorCode(EPERM); // See crbug.com/160157.
58 default: 61 default:
59 // Default on the content baseline policy. 62 // Default on the content baseline policy.
60 return SandboxBPFBasePolicy::EvaluateSyscall(sandbox, sysno); 63 return SandboxBPFBasePolicy::EvaluateSyscall(sandbox, sysno);
61 } 64 }
62 } 65 }
63 66
64 } // namespace content 67 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698