LayoutTests/editing/undo/undo-set-selection-crash.html - Issue 326323003: Fix a crash caused by invalid selection set by Undo command.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/undo/undo-set-selection-crash.html

Issue 326323003: Fix a crash caused by invalid selection set by Undo command. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revise test. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <div id="test-div" contentEditable="true"><select></div>
	yosin_UTC9 2014/06/12 06:38:10 nit: It it better to have "</select>". Does omitti nit: It it better to have "</select>". Does omitting "</select>" cause crash? Yuta Kitamura 2014/06/12 07:34:49 Oops, I thought the close tag was omissible just l Show quoted text On 2014/06/12 06:38:10, yosi wrote: > nit: It it better to have "</select>". Does omitting "</select>" cause crash? Oops, I thought the close tag was omissible just like <input>, but it wasn't. Fixed.
	8 <script>

	9 description('Undo command should not make a selection anchored in another docume nt.');

	10

	11 window.jsTestIsAsync = true;

	12

	13 var div = document.getElementById('test-div');

	14
	yosin_UTC9 2014/06/12 06:38:10 nit: We don't need to have this extra blank line. nit: We don't need to have this extra blank line. Yuta Kitamura 2014/06/12 07:34:49 Done. Show quoted text On 2014/06/12 06:38:10, yosi wrote: > nit: We don't need to have this extra blank line. Done.
	15 var selection = window.getSelection();

	16

	17 div.focus();

	18 document.execCommand('SelectAll');

	19 document.execCommand('Indent');

	20 document.execCommand('Outdent');

	21

	22 var anotherDocument = document.implementation.createHTMLDocument('');

	23 anotherDocument.body.appendChild(selection.getRangeAt(0).extractContents());

	24

	25 div.contentEditable = false;

	26

	27 document.execCommand('Undo');

	28 document.execCommand('FindString', false, 'x');

	29

	30 window.setTimeout(function () {

	31 document.body.removeChild(div);

	32 testPassed('Did not crash.');

	33 finishJSTest();

	34 }, 0);

	35 </script>

	36 </body>

	37 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/undo/undo-set-selection-crash-expected.txt » ('j') | no next file with comments »