Adding a way to remove an intent callback.

Adding a way to remove an intent callback.

Adding a method that allow removal of callbacks registered for an intent
result.

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236952

[David Trainor- moved to gerrit, 2013-11-19 23:27:39]

https://chromiumcodereview.appspot.com/32543003/diff/30001/ui/android/java/sr...
File ui/android/java/src/org/chromium/ui/base/WindowAndroid.java (right):

https://chromiumcodereview.appspot.com/32543003/diff/30001/ui/android/java/sr...
ui/android/java/src/org/chromium/ui/base/WindowAndroid.java:66: public boolean
removeIntentCallback(IntentCallback callback) {
Is this meant to cancel the action?  If not, should we just null out the
callback and leave the item in the map so that we still consume the requestcode
response?

Just a suggestion, I'm fine with this approach as well.

[David Trainor- moved to gerrit, 2013-11-19 23:27:44]

lgtm

[Jay Civelli, 2013-11-20 00:46:39]

https://codereview.chromium.org/32543003/diff/30001/ui/android/java/src/org/c...
File ui/android/java/src/org/chromium/ui/base/WindowAndroid.java (right):

https://codereview.chromium.org/32543003/diff/30001/ui/android/java/src/org/c...
ui/android/java/src/org/chromium/ui/base/WindowAndroid.java:66: public boolean
removeIntentCallback(IntentCallback callback) {
On 2013/11/19 23:27:39, David Trainor wrote:
> Is this meant to cancel the action?  If not, should we just null out the
> callback and leave the item in the map so that we still consume the
requestcode
> response?
> 
> Just a suggestion, I'm fine with this approach as well.
You mean removing the callback from mOutstandingIntents but leaving the
requestCode in mIntentErrors?
That means we would't  trigger the callback, but we would show an error message,
right?

[Jay Civelli, 2013-11-21 20:12:21]

Adding Newt for owner review.

[Jay Civelli, 2013-11-22 19:27:59]

Ping

[newt (away), 2013-11-22 19:33:47]

lgtm

Jay, I thought you said "no rush"? ;)

[commit-bot: I haz the power, 2013-11-23 00:55:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/32543003/30001

[commit-bot: I haz the power, 2013-11-23 01:35:55]

Retried try job too often on linux_rel for step(s) check_deps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-23 01:41:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/32543003/400001

[commit-bot: I haz the power, 2013-11-23 19:03:10]

Change committed as 236952