Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9157)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 324463003: ChromeOS login webui refactoring : Simplify login methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge with ToT Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index a80ebb1150e0fd703f84944669efbf988180323c..5fb98917fd3c01e3d3537c22dd4fd81876c04172 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -979,7 +979,7 @@ void SigninScreenHandler::HandleAuthenticateUser(const std::string& username,
return;
UserContext user_context(username);
user_context.SetKey(Key(password));
- delegate_->Login(user_context);
+ delegate_->Login(user_context, SigninSpecifics());
}
void SigninScreenHandler::HandleAttemptUnlock(const std::string& username) {
@@ -1004,13 +1004,15 @@ void SigninScreenHandler::HandleAttemptUnlock(const std::string& username) {
}
void SigninScreenHandler::HandleLaunchDemoUser() {
+ UserContext context(User::USER_TYPE_RETAIL_MODE, std::string());
if (delegate_)
- delegate_->LoginAsRetailModeUser();
+ delegate_->Login(context, SigninSpecifics());
}
void SigninScreenHandler::HandleLaunchIncognito() {
+ UserContext context(User::USER_TYPE_GUEST, std::string());
if (delegate_)
- delegate_->LoginAsGuest();
+ delegate_->Login(context, SigninSpecifics());
}
void SigninScreenHandler::HandleShowLocallyManagedUserCreationScreen() {
@@ -1026,8 +1028,9 @@ void SigninScreenHandler::HandleShowLocallyManagedUserCreationScreen() {
void SigninScreenHandler::HandleLaunchPublicAccount(
const std::string& username) {
+ UserContext context(User::USER_TYPE_PUBLIC_ACCOUNT, username);
if (delegate_)
- delegate_->LoginAsPublicAccount(username);
+ delegate_->Login(context, SigninSpecifics());
}
void SigninScreenHandler::HandleOfflineLogin(const base::ListValue* args) {
@@ -1254,6 +1257,7 @@ void SigninScreenHandler::HandleFocusPod(const std::string& user_id) {
void SigninScreenHandler::HandleRetrieveAuthenticatedUserEmail(
double attempt_token) {
+ // TODO(antrim) : move GaiaSigninScreen dependency to GaiaSigninScreen.
email_retriever_.reset(new AuthenticatedUserEmailRetriever(
base::Bind(&SigninScreenHandler::CallJS<double, std::string>,
base::Unretained(this),
@@ -1264,7 +1268,11 @@ void SigninScreenHandler::HandleRetrieveAuthenticatedUserEmail(
void SigninScreenHandler::HandleLaunchKioskApp(const std::string& app_id,
bool diagnostic_mode) {
- delegate_->LoginAsKioskApp(app_id, diagnostic_mode);
+ UserContext context(User::USER_TYPE_KIOSK_APP, app_id);
+ SigninSpecifics specifics;
+ specifics.kiosk_diagnostic_mode = diagnostic_mode;
+ if (delegate_)
+ delegate_->Login(context, specifics);
}
bool SigninScreenHandler::AllWhitelistedUsersPresent() {
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698