Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6928)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 324463003: ChromeOS login webui refactoring : Simplify login methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index fe6a0ecf2803559439a2f1d38487598f68f05675..1b5b2dc9d0bd30e752e42a4d767fedcee6e063d9 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -981,7 +981,7 @@ void SigninScreenHandler::HandleAuthenticateUser(const std::string& username,
return;
UserContext user_context(username);
user_context.SetKey(Key(password));
- delegate_->Login(user_context);
+ delegate_->Login(user_context, SigninSpecifics());
}
void SigninScreenHandler::HandleAttemptUnlock(const std::string& username) {
@@ -1006,13 +1006,17 @@ void SigninScreenHandler::HandleAttemptUnlock(const std::string& username) {
}
void SigninScreenHandler::HandleLaunchDemoUser() {
+ UserContext context;
+ context.SetUserType(User::USER_TYPE_RETAIL_MODE);
if (delegate_)
- delegate_->LoginAsRetailModeUser();
+ delegate_->Login(context, SigninSpecifics());
}
void SigninScreenHandler::HandleLaunchIncognito() {
+ UserContext context;
+ context.SetUserType(User::USER_TYPE_GUEST);
if (delegate_)
- delegate_->LoginAsGuest();
+ delegate_->Login(context, SigninSpecifics());
}
void SigninScreenHandler::HandleShowLocallyManagedUserCreationScreen() {
@@ -1028,8 +1032,10 @@ void SigninScreenHandler::HandleShowLocallyManagedUserCreationScreen() {
void SigninScreenHandler::HandleLaunchPublicAccount(
const std::string& username) {
+ UserContext context(username);
+ context.SetUserType(User::USER_TYPE_PUBLIC_ACCOUNT);
if (delegate_)
- delegate_->LoginAsPublicAccount(username);
+ delegate_->Login(context, SigninSpecifics());
}
void SigninScreenHandler::HandleOfflineLogin(const base::ListValue* args) {
@@ -1255,6 +1261,7 @@ void SigninScreenHandler::HandleFocusPod(const std::string& user_id) {
void SigninScreenHandler::HandleRetrieveAuthenticatedUserEmail(
double attempt_token) {
+ // TODO(antrim) : move GaiaSigninScreen dependency to GaiaSigninScreen.
email_retriever_.reset(new AuthenticatedUserEmailRetriever(
base::Bind(&SigninScreenHandler::CallJS<double, std::string>,
base::Unretained(this),
@@ -1265,7 +1272,12 @@ void SigninScreenHandler::HandleRetrieveAuthenticatedUserEmail(
void SigninScreenHandler::HandleLaunchKioskApp(const std::string& app_id,
bool diagnostic_mode) {
- delegate_->LoginAsKioskApp(app_id, diagnostic_mode);
+ UserContext context(app_id);
+ context.SetUserType(User::USER_TYPE_KIOSK_APP);
+ SigninSpecifics specifics;
+ specifics.kiosk_diagnostic_mode = diagnostic_mode;
+ if (delegate_)
+ delegate_->Login(context, specifics);
}
bool SigninScreenHandler::AllWhitelistedUsersPresent() {

Powered by Google App Engine
This is Rietveld 408576698