chrome/browser/chromeos/login/signin_specifics.h - Issue 324463003: ChromeOS login webui refactoring : Simplify login methods.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/login/signin_specifics.h

Issue 324463003: ChromeOS login webui refactoring : Simplify login methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/chromeos/login/lock/webui_screen_locker.h ('K') | « chrome/browser/chromeos/login/signin/oauth2_browsertest.cc ('k') | chrome/browser/chromeos/login/signin_specifics.cc » ('j') | chrome/browser/chromeos/login/ui/login_display.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SIGNIN_SPECIFICS_H_

	6 #define CHROME_BROWSER_CHROMEOS_LOGIN_SIGNIN_SPECIFICS_H_

	7

	8 #include <string>

	9

	10 #include "chrome/browser/chromeos/login/auth/key.h"
	Nikita (slow) 2014/06/06 14:49:47 nit: Both includes are not needed. nit: Both includes are not needed. Denis Kuznetsov (DE-MUC) 2014/06/06 15:18:42 Done. Show quoted text On 2014/06/06 14:49:47, Nikita Kostylev wrote: > nit: Both includes are not needed. Done.
	11 #include "chrome/browser/chromeos/login/users/user.h"

	12

	13 namespace chromeos {

	14

	15 // This structure encapsulates some specific parameters of signin flows that are

	16 // not

	17 // general enough to be put to UserContext.

	18 struct SigninSpecifics {

	19 SigninSpecifics();

	20 std::string guest_mode_url;
	Nikita (slow) 2014/06/06 14:49:47 Were you planning to use guest_mode_url in this CL Were you planning to use guest_mode_url in this CL or later? Denis Kuznetsov (DE-MUC) 2014/06/06 15:18:42 Added accepting parameters. I will set this parame Show quoted text On 2014/06/06 14:49:47, Nikita Kostylev wrote: > Were you planning to use guest_mode_url in this CL or later? Added accepting parameters. I will set this parameter in future CLs to get rid of CreateAccount() method.
	21 bool kiosk_diagnostic_mode;

	22 };

	23

	24 } // namespace chromeos

	25

	26 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_SIGNIN_SPECIFICS_H_

OLD	NEW