Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 323943003: add wm_unittests to tryserver win8_aura (Closed)

Created:
6 years, 6 months ago by sheyang
Modified:
6 years, 6 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add wm_unittests to win8_aura tryserver This is a short-term fix to bring bots in sync with waterfall. BUG=344543 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276062

Patch Set 1 #

Patch Set 2 : use br #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M masters/master.tryserver.chromium/master.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
sheyang
6 years, 6 months ago (2014-06-09 19:33:42 UTC) #1
iannucci
Actually I think you'll want to use _br here (buildrunner). stip@ has more info.
6 years, 6 months ago (2014-06-09 20:09:49 UTC) #2
sheyang
6 years, 6 months ago (2014-06-09 23:47:36 UTC) #3
Sergey Berezin
I'll defer to other reviewers on this one.
6 years, 6 months ago (2014-06-09 23:51:28 UTC) #4
ghost stip (do not use)
lgtm. note that this doesn't require a tryserver restart
6 years, 6 months ago (2014-06-10 01:51:38 UTC) #5
chromium-reviews
I thought any changes in master.cfg require restart. Would you elaborate? Sheng > On Jun ...
6 years, 6 months ago (2014-06-10 01:53:48 UTC) #6
ghost stip (do not use)
the point of buildrunner is that these changes don't need a restart. consider buildrunner to ...
6 years, 6 months ago (2014-06-10 01:55:07 UTC) #7
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-10 15:45:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/323943003/20001
6 years, 6 months ago (2014-06-10 15:46:03 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 15:47:58 UTC) #10
commit-bot: I haz the power
Presubmit check for 323943003-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-10 15:47:59 UTC) #11
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-10 16:04:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/323943003/20001
6 years, 6 months ago (2014-06-10 16:05:02 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 16:05:51 UTC) #14
commit-bot: I haz the power
Presubmit check for 323943003-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-10 16:05:52 UTC) #15
sheyang
The CQ bit was checked by sheyang@chromium.org
6 years, 6 months ago (2014-06-10 17:44:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/323943003/20001
6 years, 6 months ago (2014-06-10 17:45:06 UTC) #17
commit-bot: I haz the power
Change committed as 276062
6 years, 6 months ago (2014-06-10 17:46:00 UTC) #18
Sergey Berezin
On 2014/06/10 01:55:07, stip wrote: > the point of buildrunner is that these changes don't ...
6 years, 6 months ago (2014-06-10 22:20:24 UTC) #19
sheyang
6 years, 6 months ago (2014-06-10 22:28:51 UTC) #20
Message was sent while issue was closed.
On 2014/06/10 22:20:24, Sergey Berezin wrote:
> On 2014/06/10 01:55:07, stip wrote:
> > the point of buildrunner is that these changes don't need a restart.
consider
> > buildrunner to be the precursor to recipes
> 
> I can understand this for chromium_factory.py, but I believe we still need a
> restart for master.cfg change, because we are adding a new test to the config.
> Unless we add the test to testfilter in CQ, and then master.cfg change is
> irrelevant?

I think runbuild.py will periodically read master.cfg to update the buildrunner
tests
dynamically.

I can see the wm_unittests added successfully: 
http://build.chromium.org/p/tryserver.chromium/builders/win8_aura/builds/2636

Powered by Google App Engine
This is Rietveld 408576698