|
|
Created:
6 years, 6 months ago by sheyang Modified:
6 years, 6 months ago CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, ilevy-cc_chromium.org Visibility:
Public. |
DescriptionAdd wm_unittests to win8_aura tryserver
This is a short-term fix to bring bots in sync with waterfall.
BUG=344543
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276062
Patch Set 1 #Patch Set 2 : use br #
Messages
Total messages: 20 (0 generated)
Actually I think you'll want to use _br here (buildrunner). stip@ has more info.
I'll defer to other reviewers on this one.
lgtm. note that this doesn't require a tryserver restart
I thought any changes in master.cfg require restart. Would you elaborate? Sheng > On Jun 9, 2014, at 6:51 PM, "stip@chromium.org" <stip@chromium.org> wrote: > > lgtm. note that this doesn't require a tryserver restart > > https://chromiumcodereview.appspot.com/323943003/ To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
the point of buildrunner is that these changes don't need a restart. consider buildrunner to be the precursor to recipes
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/323943003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 323943003-20001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** scripts/slave/unittests/recipe_simulation_test.py (8.89s) failed .........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................M.................. ====================================================================== MISSING: chromium_android:example.perf_runner_basic (/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json) ---------------------------------------------------------------------- ---------------------------------------------------------------------- Ran 524 tests in 7.044s FAILED (missing=1) Presubmit checks took 110.3s to calculate. Was the presubmit check useful? If not, run "git cl presubmit -v" to figure out which PRESUBMIT.py was run, then run git blame on the file to figure out who to ask for help.
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/323943003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 323943003-20001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** scripts/slave/unittests/recipe_simulation_test.py (8.80s) failed ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................M....................... ====================================================================== MISSING: chromium_android:example.perf_runner_basic (/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipe_modules/chromium_android/example.expected/perf_runner_basic.json) ---------------------------------------------------------------------- ---------------------------------------------------------------------- Ran 524 tests in 5.982s FAILED (missing=1) Presubmit checks took 45.6s to calculate.
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheyang@chromium.org/323943003/20001
Message was sent while issue was closed.
Change committed as 276062
Message was sent while issue was closed.
On 2014/06/10 01:55:07, stip wrote: > the point of buildrunner is that these changes don't need a restart. consider > buildrunner to be the precursor to recipes I can understand this for chromium_factory.py, but I believe we still need a restart for master.cfg change, because we are adding a new test to the config. Unless we add the test to testfilter in CQ, and then master.cfg change is irrelevant?
Message was sent while issue was closed.
On 2014/06/10 22:20:24, Sergey Berezin wrote: > On 2014/06/10 01:55:07, stip wrote: > > the point of buildrunner is that these changes don't need a restart. consider > > buildrunner to be the precursor to recipes > > I can understand this for chromium_factory.py, but I believe we still need a > restart for master.cfg change, because we are adding a new test to the config. > Unless we add the test to testfilter in CQ, and then master.cfg change is > irrelevant? I think runbuild.py will periodically read master.cfg to update the buildrunner tests dynamically. I can see the wm_unittests added successfully: http://build.chromium.org/p/tryserver.chromium/builders/win8_aura/builds/2636 |