components/nacl_loader_unittests.isolate - Issue 322333006: Isolate nacl_loader_unittests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl_loader_unittests.isolate

Issue 322333006: Isolate nacl_loader_unittests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'includes': [

6 'angle.isolate',

7 ],

8 'conditions': [	5 'conditions': [

9 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {	6 [ 'OS=="linux"', {
	Mark Seaborn 2014/06/19 21:57:16 Nit: if .isolate files are meant to follow the sam Nit: if .isolate files are meant to follow the same style as Gyp files, I'd omit the space before "'OS..." here. jln (very slow on Chromium) 2014/06/19 22:00:32 Done. Show quoted text On 2014/06/19 21:57:16, Mark Seaborn wrote: > Nit: if .isolate files are meant to follow the same style as Gyp files, I'd omit > the space before "'OS..." here. Done.
10 'variables': {	7 'variables': {

11 'command': [	8 'command': [

12 '<(PRODUCT_DIR)/gl_tests<(EXECUTABLE_SUFFIX)',	9 '<(PRODUCT_DIR)/nacl_loader_unittests',

13 ],	10 ],

14 'isolate_dependency_tracked': [	11 'isolate_dependency_tracked': [

15 '<(PRODUCT_DIR)/gl_tests<(EXECUTABLE_SUFFIX)',	12 '<(PRODUCT_DIR)/nacl_loader_unittests',

16 ],	13 ],

	14 'read_only': 1,

17 },	15 },

	16
	Mark Seaborn 2014/06/19 21:57:16 Nit: in Gyp style, there aren't usually empty line Nit: in Gyp style, there aren't usually empty lines jln (very slow on Chromium) 2014/06/19 22:00:32 Done. Show quoted text On 2014/06/19 21:57:16, Mark Seaborn wrote: > Nit: in Gyp style, there aren't usually empty lines Done.
18 }],	17 }],

19 ],	18 ],

	19 'includes': [

	20 '../sandbox/sandbox_linux_unittests.isolate',

	21 ],

20 }	22 }

OLD	NEW

« no previous file with comments | « components/nacl.gyp ('k') | no next file » | no next file with comments »