content/browser/renderer_host/render_widget_host_view_android.cc - Issue 322203002: Add an interface to gather text surrounding the selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 322203002: Add an interface to gather text surrounding the selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@surroundings-patch-5

Patch Set: Comments, and handle any case where the renderer crashes differently. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/public/browser/android/content_view_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 120161d67e823db56a39e5bace562b2155e70849..5a7880b1f78062ad37049070733f57205214d71c 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -437,6 +437,10 @@ void RenderWidgetHostViewAndroid::OnTextSurroundingSelectionResponse(

const base::string16& content,

size_t start_offset,

size_t end_offset) {

+ if (!content_view_core_)

+ return;

+ content_view_core_->OnTextSurroundingSelectionResponse(

+ content, start_offset, end_offset);

}

void RenderWidgetHostViewAndroid::ReleaseLocksOnSurface() {