Add an interface to gather text surrounding the selection.

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 19 matching lines @@
 #include "content/browser/renderer_host/input/web_input_event_builders_android.h"
 #include "content/browser/renderer_host/input/web_input_event_util.h"
 #include "content/browser/renderer_host/java/java_bound_object.h"
 #include "content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/browser/screen_orientation/screen_orientation_dispatcher_host.h"
 #include "content/browser/ssl/ssl_host_state.h"
 #include "content/browser/web_contents/web_contents_view_android.h"
+#include "content/common/frame_messages.h"
 #include "content/common/input/web_input_event_traits.h"
 #include "content/common/input_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/favicon_status.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
@@ skipping 165 matching lines @@
     ui::WindowAndroid* window_android,
     jobject java_bridge_retained_object_set)
     : WebContentsObserver(web_contents),
       java_ref_(env, obj),
       web_contents_(static_cast<WebContentsImpl*>(web_contents)),
       root_layer_(cc::SolidColorLayer::Create()),
       dpi_scale_(GetPrimaryDisplayDeviceScaleFactor()),
       view_android_(view_android),
       window_android_(window_android),
       device_orientation_(0),
-      accessibility_enabled_(false) {
+      accessibility_enabled_(false),
+      text_surroundings_delegate_(NULL) {
   CHECK(web_contents) <<
       "A ContentViewCoreImpl should be created with a valid WebContents.";
 
   root_layer_->SetBackgroundColor(GetBackgroundColor(env, obj));
   gfx::Size physical_size(
       Java_ContentViewCore_getPhysicalBackingWidthPix(env, obj),
       Java_ContentViewCore_getPhysicalBackingHeightPix(env, obj));
   root_layer_->SetBounds(physical_size);
   root_layer_->SetIsDrawable(true);
 
   // Currently, the only use case we have for overriding a user agent involves
   // spoofing a desktop Linux user agent for "Request desktop site".
   // Automatically set it for all WebContents so that it is available when a
   // NavigationEntry requires the user agent to be overridden.
   const char kLinuxInfoStr[] = "X11; Linux x86_64";
   std::string product = content::GetContentClient()->GetProduct();
   std::string spoofed_ua =
       BuildUserAgentFromOSAndProduct(kLinuxInfoStr, product);
   web_contents->SetUserAgentOverride(spoofed_ua);
 
   java_bridge_dispatcher_host_manager_.reset(
       new JavaBridgeDispatcherHostManager(web_contents,
                                           java_bridge_retained_object_set));
-

[jdduke (slow), 2014/06/17 22:43:26]

Hmm, did you remove this line break? If so, maybe undo to reduce git blame noise
(can't tell if it was from the rebase).

[donnd, 2014/06/18 00:09:58]

Looks like I did -- replaced.

   InitWebContents();
 }
 
 ContentViewCoreImpl::~ContentViewCoreImpl() {
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
   java_ref_.reset();
   if (!j_obj.is_null()) {
     Java_ContentViewCore_onNativeContentViewCoreDestroyed(
         env, j_obj.obj(), reinterpret_cast<intptr_t>(this));
@@ skipping 1271 matching lines @@
     // If it was actually enabled globally, enable it for this RenderWidget now.
     if (accessibility_state->IsAccessibleBrowser() && host_impl)
       host_impl->AddAccessibilityMode(AccessibilityModeComplete);
   } else {
     accessibility_state->ResetAccessibilityMode();
     if (host_impl)
       host_impl->ResetAccessibilityMode();
   }
 }
 
+void ContentViewCoreImpl::SetTextSurroundingsDelegate(
+    TextSurroundingsDelegate* delegate) {
+  text_surroundings_delegate_ = delegate;
+}
+
+void ContentViewCoreImpl::OnTextSurroundingSelectionResponse(
+    const base::string16& content,
+    int start_offset,
+    int end_offset) {
+  if (text_surroundings_delegate_ != NULL) {

[jdduke (slow), 2014/06/17 22:43:26]

Nit, no need for "!= NULL", you can just do:

if (text_surroundings_delegate_)

[donnd, 2014/06/18 00:09:58]

Done.

+    text_surroundings_delegate_->OnTextSurroundingSelectionResponse(
+        content, start_offset, end_offset);
+  }
+}
+
 void ContentViewCoreImpl::SendOrientationChangeEventInternal() {
   RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();
   if (rwhv)
     rwhv->UpdateScreenInfo(GetViewAndroid());
 
   // TODO(mlamouri): temporary plumbing for Screen Orientation, this will change
   // in the future. The OnResize IPC message sent from UpdateScreenInfo() will
   // propagate the information.
   blink::WebScreenOrientationType orientation =
       blink::WebScreenOrientationPortraitPrimary;
@@ skipping 46 matching lines @@
   return GetRenderProcessIdFromRenderViewHost(
       web_contents_->GetRenderViewHost());
 }
 
 void ContentViewCoreImpl::SetBackgroundOpaque(JNIEnv* env, jobject jobj,
     jboolean opaque) {
   if (GetRenderWidgetHostViewAndroid())
     GetRenderWidgetHostViewAndroid()->SetBackgroundOpaque(opaque);
 }
 
+void ContentViewCoreImpl::RequestTextSurroundingSelection(
+    int max_length) const {
+  RenderFrameHost* focused_frame = web_contents_->GetFocusedFrame();

[jdduke (slow), 2014/06/17 22:43:26]

What guarantees do we have that focused_frame will be non-NULL?

[jdduke (slow), 2014/06/17 22:43:26]

Should we enforce that |text_surroundings_delegate_| is non-NULL here (i.e.,
|DCHECK(text_surroundings_delegate_);|)? If it should always be non-NULL for
your use-case let's go ahead and add that so that somebody doesn't come along
and just start using the API without addressing how the response would be
routed.  It's OK not to enforce that condition on the response, as the delegate
may have gone away in the meantime.

[donnd, 2014/06/18 00:09:58]

Good idea to check it.  I'm cribbing off of Mounir's CL here, so I just figured
he'd know, but doesn't hurt to check!  I think he figured there needed to be a
focused frame to have a selection, but maybe this method could be called without
a selection or selected frame.

[donnd, 2014/06/18 00:09:58]

Done.

+  focused_frame->Send(new FrameMsg_TextSurroundingSelectionRequest(
+      focused_frame->GetRoutingID(), max_length));
+}
+
 void ContentViewCoreImpl::OnSmartClipDataExtracted(
     const base::string16& result) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null())
     return;
   ScopedJavaLocalRef<jstring> jresult = ConvertUTF16ToJavaString(env, result);
   Java_ContentViewCore_onSmartClipDataExtracted(
       env, obj.obj(), jresult.obj());
 }
@@ skipping 19 matching lines @@
       reinterpret_cast<ui::WindowAndroid*>(window_android),
       retained_objects_set);
   return reinterpret_cast<intptr_t>(view);
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content