Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: Source/devtools/front_end/sdk/StylesSourceMapping.js

Issue 319143002: DevTools: introduce WebInspector.Throttler (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address @vsevik & @aandrey comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/StylesSourceMapping.js
diff --git a/Source/devtools/front_end/sdk/StylesSourceMapping.js b/Source/devtools/front_end/sdk/StylesSourceMapping.js
index 8acb4d57434b28a20f5502b0cd2d7ebc13565a33..950e0e2e61c9b5b92c75badb00df3f817e3a99e4 100644
--- a/Source/devtools/front_end/sdk/StylesSourceMapping.js
+++ b/Source/devtools/front_end/sdk/StylesSourceMapping.js
@@ -323,18 +323,11 @@ WebInspector.StyleFile = function(uiSourceCode, mapping)
this._mapping = mapping;
this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyChanged, this._workingCopyChanged, this);
this._uiSourceCode.addEventListener(WebInspector.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCommitted, this);
+ this._commitThrottler = new WebInspector.Throttler(WebInspector.StyleFile.updateTimeout);
}
WebInspector.StyleFile.updateTimeout = 200;
-/**
- * @enum {string}
- */
-WebInspector.StyleFile.PendingChangeType = {
- Major: "Major",
- Minor: "Minor"
-}
-
WebInspector.StyleFile.prototype = {
/**
* @param {!WebInspector.Event} event
@@ -344,8 +337,8 @@ WebInspector.StyleFile.prototype = {
if (this._isAddingRevision)
return;
- this._pendingChangeType = WebInspector.StyleFile.PendingChangeType.Major;
- this._maybeProcessChange();
+ this._isMajorChangePending = true;
+ this._commitThrottler.schedule(this._commitIncrementalEdit.bind(this), true);
},
/**
@@ -356,59 +349,27 @@ WebInspector.StyleFile.prototype = {
if (this._isAddingRevision)
return;
- if (this._pendingChangeType === WebInspector.StyleFile.PendingChangeType.Major)
- return;
- this._pendingChangeType = WebInspector.StyleFile.PendingChangeType.Minor;
- this._maybeProcessChange();
- },
-
- _maybeProcessChange: function()
- {
- if (this._isSettingContent)
- return;
- if (!this._pendingChangeType)
- return;
-
- if (this._pendingChangeType === WebInspector.StyleFile.PendingChangeType.Major) {
- this._clearIncrementalUpdateTimer();
- delete this._pendingChangeType;
- this._commitIncrementalEdit(true);
- return;
- }
-
- if (this._incrementalUpdateTimer)
- return;
- this._incrementalUpdateTimer = setTimeout(this._commitIncrementalEdit.bind(this, false), WebInspector.StyleFile.updateTimeout);
+ this._commitThrottler.schedule(this._commitIncrementalEdit.bind(this), false);
},
/**
- * @param {boolean} majorChange
+ * @param {!WebInspector.Throttler.FinishCallback} finishCallback
*/
- _commitIncrementalEdit: function(majorChange)
+ _commitIncrementalEdit: function(finishCallback)
{
- this._clearIncrementalUpdateTimer();
- delete this._pendingChangeType;
- this._isSettingContent = true;
- this._mapping._setStyleContent(this._uiSourceCode, this._uiSourceCode.workingCopy(), majorChange, this._styleContentSet.bind(this));
+ this._mapping._setStyleContent(this._uiSourceCode, this._uiSourceCode.workingCopy(), this._isMajorChangePending, this._styleContentSet.bind(this, finishCallback));
+ this._isMajorChangePending = false;
},
/**
+ * @param {!WebInspector.Throttler.FinishCallback} finishCallback
* @param {?string} error
*/
- _styleContentSet: function(error)
+ _styleContentSet: function(finishCallback, error)
{
if (error)
this._mapping._cssModel.target().consoleModel.showErrorMessage(error);
- delete this._isSettingContent;
- this._maybeProcessChange();
- },
-
- _clearIncrementalUpdateTimer: function()
- {
- if (!this._incrementalUpdateTimer)
- return;
- clearTimeout(this._incrementalUpdateTimer);
- delete this._incrementalUpdateTimer;
+ finishCallback();
},
/**

Powered by Google App Engine
This is Rietveld 408576698