Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 317853002: Set the first party for cookies url in RenderFrame (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set the first party for cookies url in RenderFrame This CL sets the first party for cookies url in RenderFrameImpl::willSendRequest. It is currently done in blink, but this will be removed by https://chromiumcodereview.appspot.com/314093002/. BUG=376025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275247

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Addressed Przemek's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/renderer/render_frame_impl.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
clamy
@ppi: PTAL
6 years, 6 months ago (2014-06-05 09:47:14 UTC) #1
ppi
lgtm, one question below, thanks! https://codereview.chromium.org/317853002/diff/40001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/317853002/diff/40001/content/renderer/render_frame_impl.cc#newcode2362 content/renderer/render_frame_impl.cc:2362: request.setFirstPartyForCookies(frame->top()->document().url()); Does it matter ...
6 years, 6 months ago (2014-06-05 15:27:16 UTC) #2
clamy
@jam: PTAL @ppi: thanks! https://chromiumcodereview.appspot.com/317853002/diff/40001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://chromiumcodereview.appspot.com/317853002/diff/40001/content/renderer/render_frame_impl.cc#newcode2362 content/renderer/render_frame_impl.cc:2362: request.setFirstPartyForCookies(frame->top()->document().url()); On 2014/06/05 15:27:16, ppi ...
6 years, 6 months ago (2014-06-05 15:33:27 UTC) #3
ppi
https://codereview.chromium.org/317853002/diff/40001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/317853002/diff/40001/content/renderer/render_frame_impl.cc#newcode2362 content/renderer/render_frame_impl.cc:2362: request.setFirstPartyForCookies(frame->top()->document().url()); I agree it's probably fine, but the function ...
6 years, 6 months ago (2014-06-05 15:41:42 UTC) #4
clamy
https://chromiumcodereview.appspot.com/317853002/diff/40001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://chromiumcodereview.appspot.com/317853002/diff/40001/content/renderer/render_frame_impl.cc#newcode2362 content/renderer/render_frame_impl.cc:2362: request.setFirstPartyForCookies(frame->top()->document().url()); On 2014/06/05 15:41:43, ppi wrote: > I agree ...
6 years, 6 months ago (2014-06-05 16:04:59 UTC) #5
jam
lgtm
6 years, 6 months ago (2014-06-05 19:06:52 UTC) #6
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-05 19:43:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/317853002/60001
6 years, 6 months ago (2014-06-05 19:45:38 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 20:53:40 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 21:23:22 UTC) #10
Message was sent while issue was closed.
Change committed as 275247

Powered by Google App Engine
This is Rietveld 408576698