Remove the setting of first party for cookies from addAdditionalRequestHeaders

Remove the setting of first party for cookies from addAdditionalRequestHeaders

This CL removes the setting of the first party for cookies url from
FrameFetchContext::addAdditionalRequestHeaders. For request going through the
ResourceFetcher, it will be added in content::RenderFrameImpl::willSendRequest (see https://chromiumcodereview.appspot.com/317853002/).
Other users of the function (BeaconLoader, PingLoader) can use a new specific
function of FetchContext.

BUG=376025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176219

[clamy, 2014-06-05 09:47:54]

@ppi: PTAL

[ppi, 2014-06-05 16:08:18]

lgtm, thanks!

[Nate Chapin, 2014-06-05 16:11:54]

lgtm

[clamy, 2014-06-05 16:15:53]

Thanks for the review!

[clamy, 2014-06-06 09:01:12]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2014-06-06 09:01:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/20001

[commit-bot: I haz the power, 2014-06-06 10:07:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7121)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10562)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10956)

[commit-bot: I haz the power, 2014-06-06 10:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 10:10:54]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7130)

[clamy, 2014-06-13 10:47:16]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2014-06-13 10:47:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/20001

[commit-bot: I haz the power, 2014-06-13 10:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 10:47:59]

Failed to apply patch for Source/core/loader/FrameFetchContext.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/loader/FrameFetchContext.cpp
  Hunk #1 FAILED at 80.
  Hunk #2 succeeded at 93 (offset -15 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/loader/FrameFetchContext.cpp.rej

Patch:       Source/core/loader/FrameFetchContext.cpp
Index: Source/core/loader/FrameFetchContext.cpp
diff --git a/Source/core/loader/FrameFetchContext.cpp
b/Source/core/loader/FrameFetchContext.cpp
index
00cea97c9dddc9b55deb7344e15646cd998da983..421196f8ec7c37e03b44c2046ac985c57b63323e
100644
--- a/Source/core/loader/FrameFetchContext.cpp
+++ b/Source/core/loader/FrameFetchContext.cpp
@@ -80,11 +80,6 @@ void FrameFetchContext::addAdditionalRequestHeaders(Document*
document, Resource
         FrameLoader::addHTTPOriginIfNeeded(request,
AtomicString(outgoingOrigin));
     }
 
-    if (isMainResource && m_frame->isMainFrame())
-        request.setFirstPartyForCookies(request.url());
-    else if (m_frame->tree().top()->isLocalFrame())
-       
request.setFirstPartyForCookies(m_frame->tree().top()->document()->firstPartyForCookies());
-
     // The remaining modifications are only necessary for HTTP and HTTPS.
     if (!request.url().isEmpty() && !request.url().protocolIsInHTTPFamily())
         return;
@@ -108,6 +103,12 @@ void
FrameFetchContext::addAdditionalRequestHeaders(Document* document, Resource
     FrameLoader::addHTTPOriginIfNeeded(request, nullAtom);
 }
 
+void FrameFetchContext::setFirstPartyForCookies(ResourceRequest& request)
+{
+    if (m_frame->tree().top()->isLocalFrame())
+       
request.setFirstPartyForCookies(m_frame->tree().top()->document()->firstPartyForCookies());
+}
+
 CachePolicy FrameFetchContext::cachePolicy(Document* document) const
 {
     if (document && document->loadEventFinished())

[clamy, 2014-06-16 09:32:01]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2014-06-16 09:32:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/40001

[commit-bot: I haz the power, 2014-06-16 11:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 11:31:34]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[clamy, 2014-06-16 12:46:16]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2014-06-16 12:46:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/60001

[commit-bot: I haz the power, 2014-06-16 15:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 15:04:21]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12107)

[clamy, 2014-06-16 15:05:51]

The CQ bit was checked by clamy@chromium.org

[commit-bot: I haz the power, 2014-06-16 15:06:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/60001

[commit-bot: I haz the power, 2014-06-16 16:23:52]

Change committed as 176219