Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 314093002: Remove the setting of first party for cookies from addAdditionalRequestHeaders (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
Nate Chapin, ppi
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the setting of first party for cookies from addAdditionalRequestHeaders This CL removes the setting of the first party for cookies url from FrameFetchContext::addAdditionalRequestHeaders. For request going through the ResourceFetcher, it will be added in content::RenderFrameImpl::willSendRequest (see https://chromiumcodereview.appspot.com/317853002/). Other users of the function (BeaconLoader, PingLoader) can use a new specific function of FetchContext. BUG=376025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176219

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : Fixed compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M Source/core/fetch/FetchContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/FetchContext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
clamy
@ppi: PTAL
6 years, 6 months ago (2014-06-05 09:47:54 UTC) #1
ppi
lgtm, thanks!
6 years, 6 months ago (2014-06-05 16:08:18 UTC) #2
Nate Chapin
lgtm
6 years, 6 months ago (2014-06-05 16:11:54 UTC) #3
clamy
Thanks for the review!
6 years, 6 months ago (2014-06-05 16:15:53 UTC) #4
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-06 09:01:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/20001
6 years, 6 months ago (2014-06-06 09:01:33 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 10:07:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 10:10:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7130)
6 years, 6 months ago (2014-06-06 10:10:54 UTC) #9
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-13 10:47:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/20001
6 years, 6 months ago (2014-06-13 10:47:51 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 10:47:58 UTC) #12
commit-bot: I haz the power
Failed to apply patch for Source/core/loader/FrameFetchContext.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-13 10:47:59 UTC) #13
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-16 09:32:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/40001
6 years, 6 months ago (2014-06-16 09:32:26 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 11:31:33 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/27945)
6 years, 6 months ago (2014-06-16 11:31:34 UTC) #17
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-16 12:46:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/60001
6 years, 6 months ago (2014-06-16 12:46:42 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 15:04:20 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12107)
6 years, 6 months ago (2014-06-16 15:04:21 UTC) #21
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-16 15:05:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/314093002/60001
6 years, 6 months ago (2014-06-16 15:06:19 UTC) #23
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 16:23:52 UTC) #24
Message was sent while issue was closed.
Change committed as 176219

Powered by Google App Engine
This is Rietveld 408576698