Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 313313002: Set the default accept header for main resources in RenderFrame (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set the default accept header for main resources in RenderFrame Currently it is set in blink in FrameFetchContext::addAdditionalRequestHeaders. This CL moves it to RenderFrameImpl::willSendRequest. BUG=376025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275241

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 chunks +14 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
clamy
@ppi: PTAL
6 years, 6 months ago (2014-06-05 14:01:40 UTC) #1
ppi
Thanks, one question below. https://codereview.chromium.org/313313002/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/313313002/diff/20001/content/renderer/render_frame_impl.cc#newcode2413 content/renderer/render_frame_impl.cc:2413: // already. In which circumstances ...
6 years, 6 months ago (2014-06-05 15:10:10 UTC) #2
clamy
https://chromiumcodereview.appspot.com/313313002/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://chromiumcodereview.appspot.com/313313002/diff/20001/content/renderer/render_frame_impl.cc#newcode2413 content/renderer/render_frame_impl.cc:2413: // already. On 2014/06/05 15:10:10, ppi wrote: > In ...
6 years, 6 months ago (2014-06-05 15:22:01 UTC) #3
ppi
lgtm, thanks!
6 years, 6 months ago (2014-06-05 16:09:09 UTC) #4
clamy
@jam: PTAL @ppi: thanks!
6 years, 6 months ago (2014-06-05 16:14:40 UTC) #5
clamy
@jam: PTAL
6 years, 6 months ago (2014-06-05 16:15:22 UTC) #6
jam
lgtm
6 years, 6 months ago (2014-06-05 19:07:22 UTC) #7
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-05 19:43:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/313313002/20001
6 years, 6 months ago (2014-06-05 19:45:36 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 21:14:10 UTC) #10
Message was sent while issue was closed.
Change committed as 275241

Powered by Google App Engine
This is Rietveld 408576698