Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: Source/bindings/dart/DartScriptWrappable.h

Issue 313183003: [dartium] Use ScriptWrappable when there are multiple Dart wrappers. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/1985
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/dart/DartDOMWrapper.h ('k') | Source/bindings/dart/custom/DartWindowCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 ASSERT(domData); 68 ASSERT(domData);
69 if (LIKELY(m_wrapperOrTypeInfo.isWrapperTypeInfo() || m_wrapperOrTypeInfo.is V8Wrapper())) { 69 if (LIKELY(m_wrapperOrTypeInfo.isWrapperTypeInfo() || m_wrapperOrTypeInfo.is V8Wrapper())) {
70 DartWrapperInfo* wrapperInfo = new DartWrapperInfo; 70 DartWrapperInfo* wrapperInfo = new DartWrapperInfo;
71 wrapperInfo->v8WrapperOrTypeInfo = m_wrapperOrTypeInfo; 71 wrapperInfo->v8WrapperOrTypeInfo = m_wrapperOrTypeInfo;
72 wrapperInfo->domData = domData; 72 wrapperInfo->domData = domData;
73 wrapperInfo->wrapper = wrapper; 73 wrapperInfo->wrapper = wrapper;
74 m_wrapperOrTypeInfo = TaggedPointer(wrapperInfo); 74 m_wrapperOrTypeInfo = TaggedPointer(wrapperInfo);
75 } else if (m_wrapperOrTypeInfo.isDartWrapperInfo()) { 75 } else if (m_wrapperOrTypeInfo.isDartWrapperInfo()) {
76 DartWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartWrapperInfo(); 76 DartWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartWrapperInfo();
77 if (wrapperInfo->domData == domData) { 77 if (wrapperInfo->domData == domData) {
78 // Replace the current wrapper (e.g., upgrading a custom element). 78 // Replace the current wrapper.
79 wrapperInfo->wrapper = wrapper; 79 wrapperInfo->wrapper = wrapper;
80 } else { 80 } else {
81 // Inflate to a multiwrapper, unimplemented. 81 // Inflate to a multiwrapper.
82 DartMultiWrapperInfo* multiWrapperInfo = new DartMultiWrapperInfo;
83 multiWrapperInfo->v8WrapperOrTypeInfo = wrapperInfo->v8WrapperOrType Info;
84 multiWrapperInfo->domDatas.append(wrapperInfo->domData);
85 multiWrapperInfo->wrappers.append(wrapperInfo->wrapper);
86 multiWrapperInfo->domDatas.append(domData);
87 multiWrapperInfo->wrappers.append(wrapper);
88 m_wrapperOrTypeInfo = TaggedPointer(multiWrapperInfo);
89 delete wrapperInfo;
82 } 90 }
83 } else { 91 } else {
84 ASSERT(m_wrapperOrTypeInfo.isDartMultiWrapperInfo()); 92 ASSERT(m_wrapperOrTypeInfo.isDartMultiWrapperInfo());
85 // Replace or append wrapper, unimplemented. 93 DartMultiWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartMultiWrapper Info();
86 ASSERT_NOT_REACHED(); 94 size_t len = wrapperInfo->domDatas.size();
95 for (size_t i = 0; i < len; i++) {
96 if (wrapperInfo->domDatas.at(i) == domData) {
97 // Replace the current wrapper.
98 wrapperInfo->wrappers[i] = wrapper;
99 return;
100 }
101 }
102 // Append wrapper for new isolate.
103 wrapperInfo->domDatas.append(domData);
104 wrapperInfo->wrappers.append(wrapper);
87 } 105 }
88 } 106 }
89 107
90 void* ScriptWrappable::getDartWrapper(void* domData) const 108 void* ScriptWrappable::getDartWrapper(void* domData) const
91 { 109 {
92 ASSERT(domData); 110 ASSERT(domData);
93 if (m_wrapperOrTypeInfo.isDartWrapperInfo()) { 111 if (m_wrapperOrTypeInfo.isDartWrapperInfo()) {
94 DartWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartWrapperInfo(); 112 DartWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartWrapperInfo();
95 if (wrapperInfo->domData == domData) { 113 if (wrapperInfo->domData == domData) {
96 return wrapperInfo->wrapper; 114 return wrapperInfo->wrapper;
97 } 115 }
98 return 0; 116 return 0;
99 } 117 }
100 if (m_wrapperOrTypeInfo.isDartMultiWrapperInfo()) { 118 if (m_wrapperOrTypeInfo.isDartMultiWrapperInfo()) {
101 DartMultiWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartMultiWrapper Info(); 119 DartMultiWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartMultiWrapper Info();
102 for (unsigned i = 0; i < wrapperInfo->domDatas.size(); ++i) { 120 size_t len = wrapperInfo->domDatas.size();
103 if (wrapperInfo->domDatas.at(i) == domData) { 121 for (size_t i = 0; i < len; ++i) {
104 return wrapperInfo->wrappers.at(i); 122 if (wrapperInfo->domDatas[i] == domData) {
123 return wrapperInfo->wrappers[i];
105 } 124 }
106 } 125 }
107 return 0; 126 return 0;
108 } 127 }
109 ASSERT(m_wrapperOrTypeInfo.isWrapperTypeInfo() || m_wrapperOrTypeInfo.isV8Wr apper()); 128 ASSERT(m_wrapperOrTypeInfo.isWrapperTypeInfo() || m_wrapperOrTypeInfo.isV8Wr apper());
110 return 0; 129 return 0;
111 } 130 }
112 131
113 void ScriptWrappable::clearDartWrapper(void* domData, void* wrapper) 132 void ScriptWrappable::clearDartWrapper(void* domData, void* wrapper)
114 { 133 {
115 if (LIKELY(m_wrapperOrTypeInfo.isDartWrapperInfo())) { 134 if (LIKELY(m_wrapperOrTypeInfo.isDartWrapperInfo())) {
116 DartWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartWrapperInfo(); 135 DartWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartWrapperInfo();
117 // FIXMEDART: Replace conditional with assert when wrappers for multiple isolates are implemented. 136 ASSERT(domData == wrapperInfo->domData);
118 if (domData == wrapperInfo->domData) {
119 #ifdef DEBUG 137 #ifdef DEBUG
120 DartApiScope scope; 138 DartApiScope scope;
121 ASSERT(Dart_IdentityEquals((Dart_Handle)wrapper, (Dart_Handle)wrappe rInfo->wrapper)); 139 ASSERT(Dart_IdentityEquals((Dart_Handle)wrapper, (Dart_Handle)wrapperInf o->wrapper));
122 #endif 140 #endif
123 m_wrapperOrTypeInfo = wrapperInfo->v8WrapperOrTypeInfo; 141 m_wrapperOrTypeInfo = wrapperInfo->v8WrapperOrTypeInfo;
124 delete wrapperInfo; 142 delete wrapperInfo;
143 } else if (m_wrapperOrTypeInfo.isDartMultiWrapperInfo()) {
144 // Remove.
145 DartMultiWrapperInfo* wrapperInfo = m_wrapperOrTypeInfo.dartMultiWrapper Info();
146 size_t len = wrapperInfo->domDatas.size();
147 for (size_t i = 0; i < len; i++) {
148 if (wrapperInfo->domDatas[i] == domData) {
149 #ifdef DEBUG
150 DartApiScope scope;
151 ASSERT(Dart_IdentityEquals((Dart_Handle)wrapper, (Dart_Handle)wr apperInfo->wrapper));
152 #endif
153 wrapperInfo->domDatas.remove(i);
154 wrapperInfo->wrappers.remove(i);
155 if (len == 1) {
156 // All Dart wrappers have been deleted: deflate to just a V8 wrapper or type info.
157 m_wrapperOrTypeInfo = wrapperInfo->v8WrapperOrTypeInfo;
158 delete wrapperInfo;
159 }
160 return;
161 }
125 } 162 }
126 } else if (m_wrapperOrTypeInfo.isDartMultiWrapperInfo()) { 163 // Could not find wrapper.
127 // Remove or deflate, unimplemented.
128 ASSERT_NOT_REACHED(); 164 ASSERT_NOT_REACHED();
129 } else { 165 } else {
130 // Already clear. 166 // No Dart wrappers.
131 // FIXMEDART: Uncomment assert when wrappers for multiple isolates are i mplemented. 167 ASSERT_NOT_REACHED();
132 // ASSERT_NOT_REACHED();
133 } 168 }
134 } 169 }
135 170
136 } // namespace WebCore 171 } // namespace WebCore
137 172
138 #endif // DartScriptWrappable_h 173 #endif // DartScriptWrappable_h
OLDNEW
« no previous file with comments | « Source/bindings/dart/DartDOMWrapper.h ('k') | Source/bindings/dart/custom/DartWindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698