Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4163)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 313053007: Passing BackgroundColorSpan and UnderlineSpan from Clank to Blink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index b6a62124b8de499a2562d975c27b5a64f8dd8a6d..e5e26e48b0ce3b83001101a52f52d792682b293e 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -280,7 +280,8 @@ void ExtractUnderlines(
[colorAttr colorUsingColorSpaceName:NSDeviceRGBColorSpace]);
}
underlines->push_back(blink::WebCompositionUnderline(
- range.location, NSMaxRange(range), color, [style intValue] > 1));
+ range.location, NSMaxRange(range), color, [style intValue] > 1,
+ SK_ColorTRANSPARENT));
}
i = range.location + range.length;
}
@@ -3672,7 +3673,8 @@ extern NSString *NSTextInputReplacementRangeAttributeName;
} else {
// Use a thin black underline by default.
underlines_.push_back(
- blink::WebCompositionUnderline(0, length, SK_ColorBLACK, false));
+ blink::WebCompositionUnderline(0, length, SK_ColorBLACK, false,
+ SK_ColorTRANSPARENT));
}
// If we are handling a key down event, then SetComposition() will be

Powered by Google App Engine
This is Rietveld 408576698