Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 311193002: DevTools: Implement debugger pause-resume through an action (Closed)

Created:
6 years, 6 months ago by apavlov
Modified:
6 years, 6 months ago
Reviewers:
vsevik, pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Implement debugger pause-resume through an action R=loislo, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175786

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M Source/devtools/front_end/ForwardedInputEventHandler.js View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 4 chunks +23 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/ShortcutRegistry.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
apavlov
6 years, 6 months ago (2014-06-04 16:11:16 UTC) #1
apavlov
PTAL
6 years, 6 months ago (2014-06-05 15:28:09 UTC) #2
vsevik
lgtm https://chromiumcodereview.appspot.com/311193002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://chromiumcodereview.appspot.com/311193002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode675 Source/devtools/front_end/sources/SourcesPanel.js:675: this._pauseButton = this._createButtonAndRegisterShortcuts("scripts-pause", "", handler, WebInspector.ShortcutsScreen.SourcesPanelShortcuts.PauseContinue); this._pauseButton = ...
6 years, 6 months ago (2014-06-06 16:41:35 UTC) #3
apavlov
https://chromiumcodereview.appspot.com/311193002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): https://chromiumcodereview.appspot.com/311193002/diff/1/Source/devtools/front_end/sources/SourcesPanel.js#newcode675 Source/devtools/front_end/sources/SourcesPanel.js:675: this._pauseButton = this._createButtonAndRegisterShortcuts("scripts-pause", "", handler, WebInspector.ShortcutsScreen.SourcesPanelShortcuts.PauseContinue); On 2014/06/06 16:41:35, ...
6 years, 6 months ago (2014-06-09 09:00:01 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 6 months ago (2014-06-09 09:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/311193002/20001
6 years, 6 months ago (2014-06-09 09:01:03 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 10:03:55 UTC) #7
Message was sent while issue was closed. 
Change committed as 175786

Powered by Google App Engine
This is Rietveld 408576698