Chromium Code Reviews Chromium Code Reviews
Issue 310463003:
DevTools: introduce TargetBreakpoints as a presentation of breakpoint and its state within target (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <script src="../../../http/tests/inspector/inspector-test.js"></script> | 3 <script src="../../../http/tests/inspector/inspector-test.js"></script> |
| 4 | 4 |
| 5 <script> | 5 <script> |
| 6 | 6 |
| 7 function test() | 7 function test() |
| 8 { | 8 { |
| 9 setTimeout(InspectorTest.completeTest, 2000); | |
|
vsevik
2014/06/04 08:15:22
Redundant
| |
| 9 var workspace; | 10 var workspace; |
| 10 var uiSourceCodes = {}; | 11 var uiSourceCodes = {}; |
| 11 var mockTarget = { | 12 var mockTarget = { |
| 12 | 13 |
| 13 id: function() | 14 id: function() |
| 14 { | 15 { |
| 15 return 1; | 16 return 1; |
| 16 } | 17 } |
| 17 }; | 18 }; |
| 18 var targetManager = { | 19 var targetManager = new WebInspector.TargetManager(); |
| 19 targets: function () { return [mockTarget]}, | 20 targetManager._targets.push(mockTarget); |
| 20 observeTargets: function() {} | |
| 21 } | |
| 22 | 21 |
| 23 var defaultMapping = { | 22 var defaultMapping = { |
| 24 rawLocationToUILocation: function(rawLocation) | 23 rawLocationToUILocation: function(rawLocation) |
| 25 { | 24 { |
| 26 return uiSourceCodes[rawLocation.scriptId].uiLocation(rawLocation.li neNumber, 0); | 25 return uiSourceCodes[rawLocation.scriptId].uiLocation(rawLocation.li neNumber, 0); |
| 27 }, | 26 }, |
| 28 | 27 |
| 29 uiLocationToRawLocation: function(uiSourceCode, lineNumber) | 28 uiLocationToRawLocation: function(uiSourceCode, lineNumber) |
| 30 { | 29 { |
| 31 if (!uiSourceCodes[uiSourceCode.url]) | 30 if (!uiSourceCodes[uiSourceCode.url]) |
| (...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 287 persistentBreakpoints = persistentBreakpoints || []; | 286 persistentBreakpoints = persistentBreakpoints || []; |
| 288 var setting = { | 287 var setting = { |
| 289 get: function() { return persistentBreakpoints; }, | 288 get: function() { return persistentBreakpoints; }, |
| 290 set: function(breakpoints) { persistentBreakpoints = breakpoints; } | 289 set: function(breakpoints) { persistentBreakpoints = breakpoints; } |
| 291 }; | 290 }; |
| 292 | 291 |
| 293 var sourceMapping = sourceMapping || defaultMapping; | 292 var sourceMapping = sourceMapping || defaultMapping; |
| 294 var debuggerModel = new DebuggerModelMock(sourceMapping); | 293 var debuggerModel = new DebuggerModelMock(sourceMapping); |
| 295 workspace = new WebInspector.Workspace(); | 294 workspace = new WebInspector.Workspace(); |
| 296 var breakpointManager = new WebInspector.BreakpointManager(setting, work space, targetManager); | 295 var breakpointManager = new WebInspector.BreakpointManager(setting, work space, targetManager); |
| 297 mockTarget.debuggerModel = debuggerModel; | 296 mockTarget.debuggerModel = debuggerModel; |
|
vsevik
2014/06/04 08:15:22
This one is redundant
| |
| 298 breakpointManager.targetAdded(mockTarget); | |
| 299 breakpointManager._networkWorkspaceBinding = new WebInspector.NetworkWor kspaceBinding(workspace); | 297 breakpointManager._networkWorkspaceBinding = new WebInspector.NetworkWor kspaceBinding(workspace); |
| 300 breakpointManager._debuggerProjectDelegate = new WebInspector.DebuggerPr ojectDelegate(workspace, "debugger:", WebInspector.projectTypes.Debugger); | 298 breakpointManager._debuggerProjectDelegate = new WebInspector.DebuggerPr ojectDelegate(workspace, "debugger:", WebInspector.projectTypes.Debugger); |
| 301 breakpointManager.addEventListener(WebInspector.BreakpointManager.Events .BreakpointAdded, breakpointAdded); | 299 breakpointManager.addEventListener(WebInspector.BreakpointManager.Events .BreakpointAdded, breakpointAdded); |
| 302 breakpointManager.addEventListener(WebInspector.BreakpointManager.Events .BreakpointRemoved, breakpointRemoved); | 300 breakpointManager.addEventListener(WebInspector.BreakpointManager.Events .BreakpointRemoved, breakpointRemoved); |
| 303 InspectorTest.addResult(" Created breakpoints manager"); | 301 InspectorTest.addResult(" Created breakpoints manager"); |
| 304 dumpBreakpointStorage(breakpointManager); | 302 dumpBreakpointStorage(breakpointManager); |
| 305 return breakpointManager; | 303 return breakpointManager; |
| 306 } | 304 } |
| 307 | 305 |
| 308 function setBreakpoint(breakpointManager, uiSourceCode, lineNumber, columnNu mber, condition, enabled) | 306 function setBreakpoint(breakpointManager, uiSourceCode, lineNumber, columnNu mber, condition, enabled) |
| (...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 786 | 784 |
| 787 </script> | 785 </script> |
| 788 | 786 |
| 789 </head> | 787 </head> |
| 790 | 788 |
| 791 <body onload="runTest()"> | 789 <body onload="runTest()"> |
| 792 <p>Tests BreakpointManager class.</p> | 790 <p>Tests BreakpointManager class.</p> |
| 793 | 791 |
| 794 </body> | 792 </body> |
| 795 </html> | 793 </html> |
| OLD | NEW |
