extensions/common/extension_messages.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_messages.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/extension_messages.cc

diff --git a/extensions/common/extension_messages.cc b/extensions/common/extension_messages.cc

index fc7c27365d57891269ce392b00c3979145cc16a0..afba3af3084174f0ef73aaf5b58c40d8d701b1bf 100644

--- a/extensions/common/extension_messages.cc

+++ b/extensions/common/extension_messages.cc

@@ -47,10 +47,9 @@ scoped_refptr<Extension> ExtensionMsg_Loaded_Params::ConvertToExtension(

scoped_refptr<Extension> extension =

Extension::Create(path, location, *manifest, creation_flags, error);

if (extension.get()) {

- extensions::PermissionsData::SetActivePermissions(

- extension.get(),

- new PermissionSet(apis, manifest_permissions,

- explicit_hosts, scriptable_hosts));

+ extensions::PermissionsData::ForExtension(extension)

+ ->SetActivePermissions(new PermissionSet(

+ apis, manifest_permissions, explicit_hosts, scriptable_hosts));

}

return extension;

}