chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc ('K') | « chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc » ('j') | extensions/browser/api/socket/socket_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

index 187be015e63ef817b40fe83775f70e993f7e3042..e6e781e9da3d39580cb08d6f114e7e718455b594 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

@@ -34,8 +34,9 @@ TEST_F(ExtensionManifestTest, ChromeURLPermissionAllowedWithFlag) {

LoadAndExpectSuccess("permission_chrome_url_invalid.json");

EXPECT_EQ("", error);

const GURL newtab_url(chrome::kChromeUINewTabURL);

- EXPECT_TRUE(PermissionsData::CanExecuteScriptOnPage(

- extension.get(), newtab_url, newtab_url, 0, NULL, -1, &error)) << error;

+ EXPECT_TRUE(PermissionsData::ForExtension(extension)->CanExecuteScriptOnPage(

+ extension, newtab_url, newtab_url, 0, NULL, -1, &error))

+ << error;

}

TEST_F(ExtensionManifestTest, ChromeResourcesPermissionValidOnlyForComponents) {