chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc ('K') | « chrome/common/extensions/api/plugins/plugins_handler.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | chrome/common/extensions/extension_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc

diff --git a/chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc b/chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc

index bbb81644a2ce772c665e5262af012fd51ea7e2c7..d88ab14511bc737dec1c3ae4ec2d983b6144e67e 100644

--- a/chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc

+++ b/chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc

@@ -17,9 +17,9 @@

#include "extensions/common/install_warning.h"

#include "extensions/common/manifest.h"

#include "extensions/common/manifest_constants.h"

+#include "extensions/common/manifest_handlers/permissions_parser.h"

#include "extensions/common/permissions/api_permission.h"

#include "extensions/common/permissions/api_permission_set.h"

-#include "extensions/common/permissions/permissions_data.h"

#include "extensions/common/permissions/permissions_info.h"

#if defined(ENABLE_CONFIGURATION_POLICY)

@@ -73,9 +73,7 @@ bool StorageSchemaManifestHandler::Parse(Extension* extension,

// If an extension declares the "storage.managed_schema" key then it gets

// the "storage" permission implicitly.

- APIPermissionSet* permission_set =

- PermissionsData::GetInitialAPIPermissions(extension);

- permission_set->insert(APIPermission::kStorage);

+ PermissionsParser::AddAPIPermission(extension, APIPermission::kStorage);

return true;

}