Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index ebd2679c6dfacddc120410fb4abaaceb1fa576a2..95110516145ac20b2cc372d53717df3f92762908 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -260,9 +260,9 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
// - The feature is enabled.
// - The extension has access to enough urls that we can't just let it run
// on those specified in the permissions.
- bool wants_all_urls =
- FeatureSwitch::scripts_require_action()->IsEnabled() &&
- PermissionsData::RequiresActionForScriptExecution(extension);
+ bool wants_all_urls = FeatureSwitch::scripts_require_action()->IsEnabled() &&
+ PermissionsData::ForExtension(extension)
+ ->RequiresActionForScriptExecution(extension);
extension_data->SetBoolean("wantsAllUrls", wants_all_urls);
extension_data->SetBoolean(
"allowAllUrls",

Powered by Google App Engine
This is Rietveld 408576698