chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc ('K') | « chrome/browser/ui/omnibox/location_bar.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | chrome/common/extensions/extension_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

index 7ec00fb9cba600ae384967565eb42c210682324c..62472546dc32c12e864d0335a738b8f86dd7522a 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

@@ -11,9 +11,9 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "extensions/common/extension.h"

+#include "extensions/common/manifest_handlers/permissions_parser.h"

#include "extensions/common/permissions/api_permission.h"

#include "extensions/common/permissions/permission_message_provider.h"

-#include "extensions/common/permissions/permissions_data.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -444,7 +444,7 @@ void AppInfoPermissionsTab::RevokeFilePermissions() {

const extensions::PermissionSet* AppInfoPermissionsTab::GetRequiredPermissions()

const {

- return extensions::PermissionsData::GetRequiredPermissions(app_);

+ return extensions::PermissionsParser::GetRequiredPermissions(app_);

}

const std::vector<base::string16>

@@ -455,7 +455,7 @@ AppInfoPermissionsTab::GetRequiredPermissionMessages() const {

const extensions::PermissionSet* AppInfoPermissionsTab::GetOptionalPermissions()

const {

- return extensions::PermissionsData::GetOptionalPermissions(app_);

+ return extensions::PermissionsParser::GetOptionalPermissions(app_);

}

const std::vector<base::string16>