chrome/browser/extensions/api/cookies/cookies_api.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cookies/cookies_api.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/cookies/cookies_api.cc

diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc

index ed95507cadf7e08a944a6417b4beee0ed08c2914..b03a05acbb9647c476966309ac6b3f015f96f646 100644

--- a/chrome/browser/extensions/api/cookies/cookies_api.cc

+++ b/chrome/browser/extensions/api/cookies/cookies_api.cc

@@ -62,7 +62,8 @@ bool ParseUrl(ChromeAsyncExtensionFunction* function,

}

// Check against host permissions if needed.

if (check_host_permissions &&

- !PermissionsData::HasHostPermission(function->GetExtension(), *url)) {

+ !PermissionsData::ForExtension(function->GetExtension())

+ ->HasHostPermission(*url)) {

function->SetError(ErrorUtils::FormatErrorMessage(

keys::kNoHostPermissionsError, url->spec()));

return false;