chrome/browser/apps/ephemeral_app_launcher.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_launcher.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_launcher.cc

diff --git a/chrome/browser/apps/ephemeral_app_launcher.cc b/chrome/browser/apps/ephemeral_app_launcher.cc

index 9aa495fb9d606ceaf4174420486be5f8e5b92931..ed6405c24a23b2a2aaa956d393ebc9147426a4ea 100644

--- a/chrome/browser/apps/ephemeral_app_launcher.cc

+++ b/chrome/browser/apps/ephemeral_app_launcher.cc

@@ -175,7 +175,8 @@ EphemeralAppLauncher::CreateInstallPrompt() const {

// Skip the prompt by returning null if the app does not need to display

// permission warnings.

extensions::PermissionMessages permissions =

- extensions::PermissionsData::GetPermissionMessages(extension_.get());

+ extensions::PermissionsData::ForExtension(extension_)

+ ->GetPermissionMessages();

if (permissions.empty())

return scoped_ptr<ExtensionInstallPrompt::Prompt>();