Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6354)

Unified Diff: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest master Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
diff --git a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
index b17d76ee0bbc72ed2572dc03076265a6cdf2b34e..bf5181cca0761855fcdfe40edae798f490f4de58 100644
--- a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
+++ b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc
@@ -68,13 +68,15 @@ TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptSigninProcess) {
scoped_refptr<const Extension> extension(CreateTestExtension("a"));
std::string error;
- EXPECT_TRUE(PermissionsData::CanExecuteScriptOnPage(
- extension.get(), kSigninUrl, kSigninUrl, -1, NULL, -1, &error)) << error;
+ EXPECT_TRUE(PermissionsData::ForExtension(extension)->CanExecuteScriptOnPage(
+ extension, kSigninUrl, kSigninUrl, -1, NULL, -1, &error))
+ << error;
// Pretend we are in the signin process. We should not be able to execute
// script.
CommandLine::ForCurrentProcess()->AppendSwitch(switches::kSigninProcess);
- EXPECT_FALSE(PermissionsData::CanExecuteScriptOnPage(
- extension.get(), kSigninUrl, kSigninUrl, -1, NULL, -1, &error)) << error;
+ EXPECT_FALSE(PermissionsData::ForExtension(extension)->CanExecuteScriptOnPage(
+ extension, kSigninUrl, kSigninUrl, -1, NULL, -1, &error))
+ << error;
}
// Tests that CanExecuteScriptOnPage returns false for the any process
@@ -84,8 +86,9 @@ TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptWebstore) {
scoped_refptr<const Extension> extension(CreateTestExtension("a"));
std::string error;
- EXPECT_TRUE(PermissionsData::CanExecuteScriptOnPage(
- extension.get(), kAnyUrl, kAnyUrl, -1, NULL, -1, &error)) << error;
+ EXPECT_TRUE(PermissionsData::ForExtension(extension)->CanExecuteScriptOnPage(
+ extension, kAnyUrl, kAnyUrl, -1, NULL, -1, &error))
+ << error;
// Pretend we are in the webstore process. We should not be able to execute
// script.
@@ -93,8 +96,9 @@ TEST_F(RendererPermissionsPolicyDelegateTest, CannotScriptWebstore) {
CreateTestExtension(extension_misc::kWebStoreAppId));
extension_dispatcher_->OnLoadedInternal(webstore_extension);
extension_dispatcher_->OnActivateExtension(extension_misc::kWebStoreAppId);
- EXPECT_FALSE(PermissionsData::CanExecuteScriptOnPage(
- extension.get(), kAnyUrl, kAnyUrl, -1, NULL, -1, &error)) << error;
+ EXPECT_FALSE(PermissionsData::ForExtension(extension)->CanExecuteScriptOnPage(
+ extension, kAnyUrl, kAnyUrl, -1, NULL, -1, &error))
+ << error;
}
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc ('k') | extensions/browser/api/socket/socket_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698