Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: extensions/common/features/permission_feature.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/features/permission_feature.h" 5 #include "extensions/common/features/permission_feature.h"
6 6
7 #include "extensions/common/permissions/permission_set.h" 7 #include "extensions/common/permissions/permission_set.h"
8 #include "extensions/common/permissions/permissions_data.h" 8 #include "extensions/common/permissions/permissions_data.h"
9 9
10 namespace extensions { 10 namespace extensions {
11 11
12 PermissionFeature::PermissionFeature() { 12 PermissionFeature::PermissionFeature() {
13 } 13 }
14 14
15 PermissionFeature::~PermissionFeature() { 15 PermissionFeature::~PermissionFeature() {
16 } 16 }
17 17
18 Feature::Availability PermissionFeature::IsAvailableToContext( 18 Feature::Availability PermissionFeature::IsAvailableToContext(
19 const Extension* extension, 19 const Extension* extension,
20 Feature::Context context, 20 Feature::Context context,
21 const GURL& url, 21 const GURL& url,
22 Feature::Platform platform) const { 22 Feature::Platform platform) const {
23 Availability availability = SimpleFeature::IsAvailableToContext(extension, 23 Availability availability = SimpleFeature::IsAvailableToContext(extension,
24 context, 24 context,
25 url, 25 url,
26 platform); 26 platform);
27 if (!availability.is_available()) 27 if (!availability.is_available())
28 return availability; 28 return availability;
29 29
30 if (extension && !PermissionsData::HasAPIPermission(extension, name())) 30 if (extension &&
31 !PermissionsData::ForExtension(extension)->HasAPIPermission(name()))
31 return CreateAvailability(NOT_PRESENT, extension->GetType()); 32 return CreateAvailability(NOT_PRESENT, extension->GetType());
32 33
33 return CreateAvailability(IS_AVAILABLE); 34 return CreateAvailability(IS_AVAILABLE);
34 } 35 }
35 36
36 std::string PermissionFeature::Parse(const base::DictionaryValue* value) { 37 std::string PermissionFeature::Parse(const base::DictionaryValue* value) {
37 std::string error = SimpleFeature::Parse(value); 38 std::string error = SimpleFeature::Parse(value);
38 if (!error.empty()) 39 if (!error.empty())
39 return error; 40 return error;
40 41
41 if (extension_types()->empty()) { 42 if (extension_types()->empty()) {
42 return name() + ": Permission features must specify at least one " + 43 return name() + ": Permission features must specify at least one " +
43 "value for extension_types."; 44 "value for extension_types.";
44 } 45 }
45 46
46 if (!GetContexts()->empty()) 47 if (!GetContexts()->empty())
47 return name() + ": Permission features do not support contexts."; 48 return name() + ": Permission features do not support contexts.";
48 49
49 return std::string(); 50 return std::string();
50 } 51 }
51 52
52 } // namespace extensions 53 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698