Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_url_handler.h" 5 #include "chrome/common/extensions/manifest_url_handler.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/common/chrome_constants.h" 14 #include "chrome/common/chrome_constants.h"
15 #include "chrome/common/extensions/extension_constants.h" 15 #include "chrome/common/extensions/extension_constants.h"
16 #include "chrome/common/url_constants.h" 16 #include "chrome/common/url_constants.h"
17 #include "extensions/common/error_utils.h" 17 #include "extensions/common/error_utils.h"
18 #include "extensions/common/file_util.h" 18 #include "extensions/common/file_util.h"
19 #include "extensions/common/manifest.h" 19 #include "extensions/common/manifest.h"
20 #include "extensions/common/manifest_constants.h" 20 #include "extensions/common/manifest_constants.h"
21 #include "extensions/common/manifest_handlers/permissions_parser.h"
21 #include "extensions/common/permissions/api_permission.h" 22 #include "extensions/common/permissions/api_permission.h"
22 #include "extensions/common/permissions/api_permission_set.h" 23 #include "extensions/common/permissions/api_permission_set.h"
23 #include "extensions/common/permissions/permissions_data.h"
24 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
25 #include "ui/base/l10n/l10n_util.h" 25 #include "ui/base/l10n/l10n_util.h"
26 26
27 #if defined(USE_AURA) 27 #if defined(USE_AURA)
28 #include "ui/keyboard/keyboard_constants.h" 28 #include "ui/keyboard/keyboard_constants.h"
29 #endif 29 #endif
30 30
31 namespace extensions { 31 namespace extensions {
32 32
33 namespace keys = manifest_keys; 33 namespace keys = manifest_keys;
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 bool DevToolsPageHandler::Parse(Extension* extension, base::string16* error) { 119 bool DevToolsPageHandler::Parse(Extension* extension, base::string16* error) {
120 scoped_ptr<ManifestURL> manifest_url(new ManifestURL); 120 scoped_ptr<ManifestURL> manifest_url(new ManifestURL);
121 std::string devtools_str; 121 std::string devtools_str;
122 if (!extension->manifest()->GetString(keys::kDevToolsPage, &devtools_str)) { 122 if (!extension->manifest()->GetString(keys::kDevToolsPage, &devtools_str)) {
123 *error = base::ASCIIToUTF16(errors::kInvalidDevToolsPage); 123 *error = base::ASCIIToUTF16(errors::kInvalidDevToolsPage);
124 return false; 124 return false;
125 } 125 }
126 manifest_url->url_ = extension->GetResourceURL(devtools_str); 126 manifest_url->url_ = extension->GetResourceURL(devtools_str);
127 extension->SetManifestData(keys::kDevToolsPage, manifest_url.release()); 127 extension->SetManifestData(keys::kDevToolsPage, manifest_url.release());
128 PermissionsData::GetInitialAPIPermissions(extension)->insert( 128 PermissionsParser::AddAPIPermission(extension, APIPermission::kDevtools);
129 APIPermission::kDevtools);
130 return true; 129 return true;
131 } 130 }
132 131
133 const std::vector<std::string> DevToolsPageHandler::Keys() const { 132 const std::vector<std::string> DevToolsPageHandler::Keys() const {
134 return SingleKey(keys::kDevToolsPage); 133 return SingleKey(keys::kDevToolsPage);
135 } 134 }
136 135
137 HomepageURLHandler::HomepageURLHandler() { 136 HomepageURLHandler::HomepageURLHandler() {
138 } 137 }
139 138
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 extension->SetManifestData(keys::kChromeURLOverrides, 324 extension->SetManifestData(keys::kChromeURLOverrides,
326 url_overrides.release()); 325 url_overrides.release());
327 return true; 326 return true;
328 } 327 }
329 328
330 const std::vector<std::string> URLOverridesHandler::Keys() const { 329 const std::vector<std::string> URLOverridesHandler::Keys() const {
331 return SingleKey(keys::kChromeURLOverrides); 330 return SingleKey(keys::kChromeURLOverrides);
332 } 331 }
333 332
334 } // namespace extensions 333 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698