Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/extensions/manifest_handlers/app_isolation_info.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h" 5 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "extensions/common/error_utils.h" 12 #include "extensions/common/error_utils.h"
13 #include "extensions/common/manifest_constants.h" 13 #include "extensions/common/manifest_constants.h"
14 #include "extensions/common/manifest_handlers/permissions_parser.h"
14 #include "extensions/common/permissions/api_permission_set.h" 15 #include "extensions/common/permissions/api_permission_set.h"
15 #include "extensions/common/permissions/permissions_data.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 namespace keys = manifest_keys; 19 namespace keys = manifest_keys;
20 20
21 AppIsolationInfo::AppIsolationInfo(bool isolated_storage) 21 AppIsolationInfo::AppIsolationInfo(bool isolated_storage)
22 : has_isolated_storage(isolated_storage) { 22 : has_isolated_storage(isolated_storage) {
23 } 23 }
24 24
25 AppIsolationInfo::~AppIsolationInfo() { 25 AppIsolationInfo::~AppIsolationInfo() {
(...skipping 15 matching lines...) Expand all
41 bool AppIsolationHandler::Parse(Extension* extension, base::string16* error) { 41 bool AppIsolationHandler::Parse(Extension* extension, base::string16* error) {
42 // Platform apps always get isolated storage. 42 // Platform apps always get isolated storage.
43 if (extension->is_platform_app()) { 43 if (extension->is_platform_app()) {
44 extension->SetManifestData(keys::kIsolation, new AppIsolationInfo(true)); 44 extension->SetManifestData(keys::kIsolation, new AppIsolationInfo(true));
45 return true; 45 return true;
46 } 46 }
47 47
48 // Other apps only get it if it is requested _and_ experimental APIs are 48 // Other apps only get it if it is requested _and_ experimental APIs are
49 // enabled. 49 // enabled.
50 if (!extension->is_app() || 50 if (!extension->is_app() ||
51 !PermissionsData::GetInitialAPIPermissions(extension)->count( 51 !PermissionsParser::HasAPIPermission(extension,
52 APIPermission::kExperimental)) { 52 APIPermission::kExperimental)) {
53 return true; 53 return true;
54 } 54 }
55 55
56 // We should only be parsing if the extension has the key in the manifest, 56 // We should only be parsing if the extension has the key in the manifest,
57 // or is a platform app (which we already handled). 57 // or is a platform app (which we already handled).
58 DCHECK(extension->manifest()->HasPath(keys::kIsolation)); 58 DCHECK(extension->manifest()->HasPath(keys::kIsolation));
59 59
60 const base::ListValue* isolation_list = NULL; 60 const base::ListValue* isolation_list = NULL;
61 if (!extension->manifest()->GetList(keys::kIsolation, &isolation_list)) { 61 if (!extension->manifest()->GetList(keys::kIsolation, &isolation_list)) {
62 *error = base::ASCIIToUTF16(manifest_errors::kInvalidIsolation); 62 *error = base::ASCIIToUTF16(manifest_errors::kInvalidIsolation);
(...skipping 26 matching lines...) Expand all
89 89
90 bool AppIsolationHandler::AlwaysParseForType(Manifest::Type type) const { 90 bool AppIsolationHandler::AlwaysParseForType(Manifest::Type type) const {
91 return type == Manifest::TYPE_PLATFORM_APP; 91 return type == Manifest::TYPE_PLATFORM_APP;
92 } 92 }
93 93
94 const std::vector<std::string> AppIsolationHandler::Keys() const { 94 const std::vector<std::string> AppIsolationHandler::Keys() const {
95 return SingleKey(keys::kIsolation); 95 return SingleKey(keys::kIsolation);
96 } 96 }
97 97
98 } // namespace extensions 98 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698