Refactor PermissionsData pt1

chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Media Galleries API.
 
 #include "chrome/browser/extensions/api/media_galleries/media_galleries_api.h"
 
 #include <set>
 #include <string>
@@ skipping 114 matching lines @@
 
 base::ListValue* ConstructFileSystemList(
     content::RenderViewHost* rvh,
     const Extension* extension,
     const std::vector<MediaFileSystemInfo>& filesystems) {
   if (!rvh)
     return NULL;
 
   MediaGalleriesPermission::CheckParam read_param(
       MediaGalleriesPermission::kReadPermission);
-  bool has_read_permission = PermissionsData::CheckAPIPermissionWithParam(
-      extension, APIPermission::kMediaGalleries, &read_param);
+  bool has_read_permission =

[not at google - send to devlin, 2014/06/02 23:20:06]

here

[Devlin, 2014/06/03 15:28:21]

Done.

+      PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+          APIPermission::kMediaGalleries, &read_param);
   MediaGalleriesPermission::CheckParam copy_to_param(
       MediaGalleriesPermission::kCopyToPermission);
-  bool has_copy_to_permission = PermissionsData::CheckAPIPermissionWithParam(
-      extension, APIPermission::kMediaGalleries, &copy_to_param);
+  bool has_copy_to_permission =
+      PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+          APIPermission::kMediaGalleries, &copy_to_param);
   MediaGalleriesPermission::CheckParam delete_param(
       MediaGalleriesPermission::kDeletePermission);
-  bool has_delete_permission = PermissionsData::CheckAPIPermissionWithParam(
-      extension, APIPermission::kMediaGalleries, &delete_param);
+  bool has_delete_permission =
+      PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+          APIPermission::kMediaGalleries, &delete_param);
 
   const int child_id = rvh->GetProcess()->GetID();
   scoped_ptr<base::ListValue> list(new base::ListValue());
   for (size_t i = 0; i < filesystems.size(); ++i) {
     scoped_ptr<base::DictionaryValue> file_system_dict_value(
         new base::DictionaryValue());
 
     // Send the file system id so the renderer can create a valid FileSystem
     // object.
     file_system_dict_value->SetStringWithoutPathExpansion(
@@ skipping 35 matching lines @@
 
   return list.release();
 }
 
 bool CheckScanPermission(const extensions::Extension* extension,
                          std::string* error) {
   DCHECK(extension);
   DCHECK(error);
   MediaGalleriesPermission::CheckParam scan_param(
       MediaGalleriesPermission::kScanPermission);
-  bool has_scan_permission = PermissionsData::CheckAPIPermissionWithParam(
-      extension, APIPermission::kMediaGalleries, &scan_param);
+  bool has_scan_permission =
+      PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(
+          APIPermission::kMediaGalleries, &scan_param);
   if (!has_scan_permission)
     *error = kNoScanPermission;
   return has_scan_permission;
 }
 
 class SelectDirectoryDialog : public ui::SelectFileDialog::Listener,
                               public base::RefCounted<SelectDirectoryDialog> {
  public:
   // Selected file path, or an empty path if the user canceled.
   typedef base::Callback<void(const base::FilePath&)> Callback;
@@ skipping 668 matching lines @@
   if (!parse_success) {
     SendResponse(false);
     return;
   }
 
   SetResult(metadata_dictionary->DeepCopy());
   SendResponse(true);
 }
 
 }  // namespace extensions