Refactor PermissionsData pt1

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 2491 matching lines @@
     }
   } else {
     // Access to public socket APIs is controlled by extension permissions.
     if (url.is_valid() && url.SchemeIs(extensions::kExtensionScheme) &&
         extension_set) {
       const Extension* extension = extension_set->GetByID(url.host());
       if (extension) {
         if (params) {
           extensions::SocketPermission::CheckParam check_params(
               params->type, params->host, params->port);
-          if (extensions::PermissionsData::CheckAPIPermissionWithParam(
-                  extension, extensions::APIPermission::kSocket,
-                  &check_params)) {
+          if (extensions::PermissionsData::ForExtension(extension)
+                  ->CheckAPIPermissionWithParam(
+                      extensions::APIPermission::kSocket, &check_params)) {
             return true;
           }
         } else {
-          if (extensions::PermissionsData::HasAPIPermission(
-                  extension, extensions::APIPermission::kSocket)) {
+          if (extensions::PermissionsData::ForExtension(extension)
+                  ->HasAPIPermission(extensions::APIPermission::kSocket)) {

[not at google - send to devlin, 2014/06/02 23:20:06]

it's true though; one of the advantages of
extensions::PermissionsData::ForExtension(..) is that you can actually hold onto
that PermissionsData. I'll point out places. here is one.

[Devlin, 2014/06/03 15:28:21]

Done.

             return true;
           }
         }
       }
     }
   }
 
   // Allow both public and private APIs if the command line says so.
   return IsHostAllowedByCommandLine(url, extension_set,
                                     switches::kAllowNaClSocketAPI);
@@ skipping 226 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome