Refactor PermissionsData pt1

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 2489 matching lines @@
     if (IsExtensionOrSharedModuleWhitelisted(url, extension_set,
                                              allowed_socket_origins_)) {
       return true;
     }
   } else {
     // Access to public socket APIs is controlled by extension permissions.
     if (url.is_valid() && url.SchemeIs(extensions::kExtensionScheme) &&
         extension_set) {
       const Extension* extension = extension_set->GetByID(url.host());
       if (extension) {
+        const extensions::PermissionsData* permissions_data =
+            extensions::PermissionsData::ForExtension(extension);
         if (params) {
           extensions::SocketPermission::CheckParam check_params(
               params->type, params->host, params->port);
-          if (extensions::PermissionsData::CheckAPIPermissionWithParam(
-                  extension, extensions::APIPermission::kSocket,
-                  &check_params)) {
+          if (permissions_data->CheckAPIPermissionWithParam(
+                  extensions::APIPermission::kSocket, &check_params)) {
             return true;
           }
-        } else {
-          if (extensions::PermissionsData::HasAPIPermission(
-                  extension, extensions::APIPermission::kSocket)) {
-            return true;
-          }
+        } else if (permissions_data->HasAPIPermission(
+                       extensions::APIPermission::kSocket)) {
+          return true;
         }
       }
     }
   }
 
   // Allow both public and private APIs if the command line says so.
   return IsHostAllowedByCommandLine(url, extension_set,
                                     switches::kAllowNaClSocketAPI);
 #else
   return false;
@@ skipping 224 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome