Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 308083009: Set the right load flag for ResourceRequests on end-to-end reloads (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set the right load flag for ResourceRequests on end-to-end reloads https://chromiumcodereview.appspot.com/309693002/ introduces a cache policy in Blink indicating end-to-end reload. It translates to the load flag net::LOAD_BYPASS_CACHE (instead of having blink set HTTP cache headers "Pragma: no-cache" and "Cache-Control: no-cache". BUG=376025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/child/web_url_loader_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
clamy
PTAL: this is the third patch in a series of 3 to introduce a new ...
6 years, 6 months ago (2014-05-30 18:21:35 UTC) #1
ppi
Makes sense, LGTM. Yay 5-way patches :).
6 years, 6 months ago (2014-06-01 23:52:56 UTC) #2
clamy
@jam: PTAL This is the third patch in a series of 5 aiming at removing ...
6 years, 6 months ago (2014-06-02 05:33:37 UTC) #3
jam
lgtm
6 years, 6 months ago (2014-06-02 06:50:50 UTC) #4
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-04 09:03:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/308083009/1
6 years, 6 months ago (2014-06-04 09:05:01 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 10:58:36 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 11:21:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/159632) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/38207)
6 years, 6 months ago (2014-06-04 11:21:33 UTC) #9
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-04 11:30:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/308083009/1
6 years, 6 months ago (2014-06-04 11:31:37 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 13:31:22 UTC) #12
Message was sent while issue was closed.
Change committed as 274807

Powered by Google App Engine
This is Rietveld 408576698