Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: components/nacl/zygote/nacl_fork_delegate_linux_unittest.cc

Issue 308073002: Clear environment variables for nacl_helper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nacl browser tests and android base tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/zygote/nacl_fork_delegate_linux_unittest.cc
diff --git a/components/nacl/zygote/nacl_fork_delegate_linux_unittest.cc b/components/nacl/zygote/nacl_fork_delegate_linux_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d29601f9fa828834754e118e8d3d8aa7bcbcb60a
--- /dev/null
+++ b/components/nacl/zygote/nacl_fork_delegate_linux_unittest.cc
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/nacl/zygote/nacl_fork_delegate_linux.h"
+
+#include "base/environment.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/process/launch.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(NaClForkDelegateLinuxTest, EnvPassthrough) {
+ scoped_ptr<base::Environment> env(base::Environment::Create());
+ const char passthrough1[] = "HELPER_PASSTHROUGH1";
+ const char passthrough2[] = "HELPER_PASSTHROUGH2";
+ const char passthrough3[] = "HELPER_PASSTHROUGH3";
+ const char passthrough4[] = "HELPER_PASSTHROUGH4";
+ const char passthrough5[] = "NACL_EXE_STDOUT";
+ const char value1[] = "passthrough_value1";
+ const char value3[] = "passthrough_value3";
+ const char value4[] = "passthrough_value4";
+ const char value5[] = "passthrough_value5";
+ std::string passthrough_value;
+ passthrough_value += passthrough1;
+ passthrough_value += ",";
+ passthrough_value += passthrough2;
+ passthrough_value += ",";
+ passthrough_value += passthrough3;
+ // Not adding passthrough4 to the passthrough variable.
+ // Not adding passthrough5 either because it is implicitly allowed.
+ env->SetVar("NACL_ENV_PASSTHROUGH", passthrough_value.c_str());
+ env->SetVar(passthrough1, value1);
+ // Intentionally skip setting a value for passthrough2.
+ env->SetVar(passthrough3, value3);
+ env->SetVar(passthrough4, value4);
+ env->SetVar(passthrough5, value5);
+
+ base::LaunchOptions options;
+ nacl::NaClForkDelegate::AddPassthroughEnvToOptions(options);
+ EXPECT_EQ(value1, options.environ[passthrough1]);
+ EXPECT_EQ(0U, options.environ.count(passthrough2));
+ EXPECT_EQ(value3, options.environ[passthrough3]);
+ EXPECT_EQ(0U, options.environ.count(passthrough4));
+ EXPECT_EQ(value5, options.environ[passthrough5]);
+}

Powered by Google App Engine
This is Rietveld 408576698