Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: components/nacl/zygote/nacl_fork_delegate_linux.h

Issue 308073002: Clear environment variables for nacl_helper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nacl browser tests and android base tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gyp ('k') | components/nacl/zygote/nacl_fork_delegate_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/zygote/nacl_fork_delegate_linux.h
diff --git a/components/nacl/zygote/nacl_fork_delegate_linux.h b/components/nacl/zygote/nacl_fork_delegate_linux.h
index 12a7c772f6853464a7166fc4347902ede6ec68f0..c62429269fc0c6ba35c487cd675c7e7708c6680b 100644
--- a/components/nacl/zygote/nacl_fork_delegate_linux.h
+++ b/components/nacl/zygote/nacl_fork_delegate_linux.h
@@ -10,8 +10,15 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
#include "content/public/common/zygote_fork_delegate_linux.h"
+FORWARD_DECLARE_TEST(NaClForkDelegateLinuxTest, EnvPassthrough);
+
+namespace base {
+struct LaunchOptions;
+}
+
template <typename>
class ScopedVector;
@@ -45,6 +52,8 @@ class NaClForkDelegate : public content::ZygoteForkDelegate {
int* exit_code) OVERRIDE;
private:
+ static void AddPassthroughEnvToOptions(base::LaunchOptions& options);
jln (very slow on Chromium) 2014/06/03 22:58:13 Style: this really should be a pointer.
elijahtaylor1 2014/06/03 23:22:10 In fairness, I *really* meant to do it, but didn't
+
// These values are reported via UMA and hence they become permanent
// constants. Old values cannot be reused, only new ones added.
enum NaClHelperStatus {
@@ -62,6 +71,8 @@ class NaClForkDelegate : public content::ZygoteForkDelegate {
NaClHelperStatus status_;
int fd_;
+ FRIEND_TEST_ALL_PREFIXES(::NaClForkDelegateLinuxTest, EnvPassthrough);
+
DISALLOW_COPY_AND_ASSIGN(NaClForkDelegate);
};
« no previous file with comments | « components/components_tests.gyp ('k') | components/nacl/zygote/nacl_fork_delegate_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698