Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 306003002: Move guest lifetime management to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/browser_plugin_guest_delegate.h
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h
index 5f76532d2a11c1a5e40f4bd931efcfac10ca2088..64626d4bea100be35023a6d6ce5abf2f3b25f6e6 100644
--- a/content/public/browser/browser_plugin_guest_delegate.h
+++ b/content/public/browser/browser_plugin_guest_delegate.h
@@ -26,9 +26,6 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// Notification that the embedder has completed attachment.
virtual void DidAttach() {}
- // Informs the delegate that the embedder has been destroyed.
- virtual void EmbedderDestroyed() {}
-
// Requests setting the zoom level to the provided |zoom_level|.
virtual void SetZoom(double zoom_factor) {}
@@ -54,7 +51,7 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {
// Registers a |callback| with the delegate that the delegate would call when
// it is about to be destroyed.
- typedef base::Callback<void(WebContents*)> DestructionCallback;
+ typedef base::Callback<void()>DestructionCallback;
lazyboy 2014/05/29 19:13:58 nit: space before DestructionCallback.
Fady Samuel 2014/05/29 21:21:12 Done.
virtual void RegisterDestructionCallback(
const DestructionCallback& callback) {}
};

Powered by Google App Engine
This is Rietveld 408576698