[Android] Add UMA SB download size in background and foreground.

chrome/browser/safe_browsing/protocol_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/protocol_manager.h"
 
 #ifndef NDEBUG
 #include "base/base64.h"
 #endif
 #include "base/environment.h"
@@ skipping 106 matching lines @@
                         kSbTimerStartIntervalSecMax))),
       update_state_(FIRST_REQUEST),
       chunk_pending_to_write_(false),
       version_(config.version),
       update_size_(0),
       client_name_(config.client_name),
       request_context_getter_(request_context_getter),
       url_prefix_(config.url_prefix),
       backup_update_reason_(BACKUP_UPDATE_REASON_MAX),
       disable_auto_update_(config.disable_auto_update),
-      url_fetcher_id_(0) {
+      url_fetcher_id_(0),
+      app_in_foreground_(true) {
   DCHECK(!url_prefix_.empty());
 
   backup_url_prefixes_[BACKUP_UPDATE_REASON_CONNECT] =
       config.backup_connect_error_url_prefix;
   backup_url_prefixes_[BACKUP_UPDATE_REASON_HTTP] =
       config.backup_http_error_url_prefix;
   backup_url_prefixes_[BACKUP_UPDATE_REASON_NETWORK] =
       config.backup_network_error_url_prefix;
 
   // Set the backoff multiplier fuzz to a random value between 0 and 1.
@@ skipping 561 matching lines @@
       &gethash_error_count_, &gethash_back_off_mult_);
   next_gethash_time_ = now + next;
 }
 
 void SafeBrowsingProtocolManager::UpdateFinished(bool success) {
   UpdateFinished(success, !success);
 }
 
 void SafeBrowsingProtocolManager::UpdateFinished(bool success, bool back_off) {
   DCHECK(CalledOnValidThread());
+#if defined(OS_ANDROID)
+  if (app_in_foreground_)
+    UMA_HISTOGRAM_COUNTS("SB2.UpdateSizeForeground", update_size_);
+  else
+    UMA_HISTOGRAM_COUNTS("SB2.UpdateSizeBackground", update_size_);
+#else
   UMA_HISTOGRAM_COUNTS("SB2.UpdateSize", update_size_);

[Scott Hess - ex-Googler, 2014/05/30 16:08:21]

This should probably just be outside the conditional entirely for consistency
across the fleet.

+#endif
   update_size_ = 0;
   bool update_success = success || request_type_ == CHUNK_REQUEST;
   if (backup_update_reason_ == BACKUP_UPDATE_REASON_MAX) {
     RecordUpdateResult(
         update_success ? UPDATE_RESULT_SUCCESS : UPDATE_RESULT_FAIL);
   } else {
     UpdateResult update_result = static_cast<UpdateResult>(
           UPDATE_RESULT_BACKUP_START +
           (static_cast<int>(backup_update_reason_) * 2) +
           update_success);
@@ skipping 63 matching lines @@
     FullHashCallback callback, bool is_download)
     : callback(callback),
       is_download(is_download) {
 }
 
 SafeBrowsingProtocolManager::FullHashDetails::~FullHashDetails() {
 }
 
 SafeBrowsingProtocolManagerDelegate::~SafeBrowsingProtocolManagerDelegate() {
 }