Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: call/video_receive_stream.h

Issue 3019453002: Delete member VideoReceiveStream::Config::Rtp::ulpfec. (Closed)
Patch Set: Added DCHECK. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « call/rampup_tests.cc ('k') | call/video_receive_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 159
160 // See draft-alvestrand-rmcat-remb for information. 160 // See draft-alvestrand-rmcat-remb for information.
161 bool remb = false; 161 bool remb = false;
162 162
163 // See draft-holmer-rmcat-transport-wide-cc-extensions for details. 163 // See draft-holmer-rmcat-transport-wide-cc-extensions for details.
164 bool transport_cc = false; 164 bool transport_cc = false;
165 165
166 // See NackConfig for description. 166 // See NackConfig for description.
167 NackConfig nack; 167 NackConfig nack;
168 168
169 // See UlpfecConfig for description. 169 // Payload types for ULPFEC and RED, respectively.
170 // TODO(nisse): UlpfecConfig includes the field red_rtx_payload_type, 170 int ulpfec_payload_type = -1;
171 // which duplicates info in the rtx_associated_payload_types mapping. So 171 int red_payload_type = -1;
172 // delete the use of UlpfecConfig here, and replace by the values which
173 // make sense in this context, likely those are ulpfec_payload_type_ and
174 // red_payload_type_.
175 UlpfecConfig ulpfec;
176 172
177 // SSRC for retransmissions. 173 // SSRC for retransmissions.
178 uint32_t rtx_ssrc = 0; 174 uint32_t rtx_ssrc = 0;
179 175
180 // Set if the stream is protected using FlexFEC. 176 // Set if the stream is protected using FlexFEC.
181 bool protected_by_flexfec = false; 177 bool protected_by_flexfec = false;
182 178
183 // Map from rtx payload type -> media payload type. 179 // Map from rtx payload type -> media payload type.
184 // For RTX to be enabled, both an SSRC and this mapping are needed. 180 // For RTX to be enabled, both an SSRC and this mapping are needed.
185 std::map<int, int> rtx_associated_payload_types; 181 std::map<int, int> rtx_associated_payload_types;
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 virtual void AddSecondarySink(RtpPacketSinkInterface* sink) = 0; 247 virtual void AddSecondarySink(RtpPacketSinkInterface* sink) = 0;
252 virtual void RemoveSecondarySink(const RtpPacketSinkInterface* sink) = 0; 248 virtual void RemoveSecondarySink(const RtpPacketSinkInterface* sink) = 0;
253 249
254 protected: 250 protected:
255 virtual ~VideoReceiveStream() {} 251 virtual ~VideoReceiveStream() {}
256 }; 252 };
257 253
258 } // namespace webrtc 254 } // namespace webrtc
259 255
260 #endif // CALL_VIDEO_RECEIVE_STREAM_H_ 256 #endif // CALL_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « call/rampup_tests.cc ('k') | call/video_receive_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698