Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: telemetry/telemetry/page/cache_temperature_unittest.py

Issue 3016563002: Rename 'warmCache' to 'warm_cache' (Closed)
Patch Set: do not remove ensure_diskcache Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « telemetry/telemetry/page/cache_temperature.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import contextlib 5 import contextlib
6 6
7 from telemetry import decorators 7 from telemetry import decorators
8 from telemetry import page as page_module 8 from telemetry import page as page_module
9 from telemetry import story 9 from telemetry import story
10 from telemetry.page import cache_temperature 10 from telemetry.page import cache_temperature
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 def testEnsureAny(self): 43 def testEnsureAny(self):
44 with self.captureTrace(): 44 with self.captureTrace():
45 story_set = story.StorySet() 45 story_set = story.StorySet()
46 page = page_module.Page( 46 page = page_module.Page(
47 'http://google.com', page_set=story_set, 47 'http://google.com', page_set=story_set,
48 cache_temperature=cache_temperature.ANY, name='http://google.com') 48 cache_temperature=cache_temperature.ANY, name='http://google.com')
49 cache_temperature.EnsurePageCacheTemperature(page, self._browser) 49 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
50 50
51 markers = self.traceMarkers() 51 markers = self.traceMarkers()
52 self.assertNotIn('telemetry.internal.ensure_diskcache.start', markers) 52 self.assertNotIn('telemetry.internal.ensure_diskcache.start', markers)
53 self.assertNotIn('telemetry.internal.warmCache.start', markers) 53 self.assertNotIn('telemetry.internal.warm_cache.start', markers)
54 54
55 @decorators.Enabled('has tabs') 55 @decorators.Enabled('has tabs')
56 @decorators.Disabled('chromeos') 56 @decorators.Disabled('chromeos')
57 def testEnsureCold(self): 57 def testEnsureCold(self):
58 with self.captureTrace(): 58 with self.captureTrace():
59 story_set = story.StorySet() 59 story_set = story.StorySet()
60 page = page_module.Page( 60 page = page_module.Page(
61 'http://google.com', page_set=story_set, 61 'http://google.com', page_set=story_set,
62 cache_temperature=cache_temperature.COLD, name='http://google.com') 62 cache_temperature=cache_temperature.COLD, name='http://google.com')
63 cache_temperature.EnsurePageCacheTemperature(page, self._browser) 63 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
(...skipping 12 matching lines...) Expand all
76 cache_temperature.EnsurePageCacheTemperature(page, self._browser) 76 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
77 77
78 previous_page = page 78 previous_page = page
79 page = page_module.Page( 79 page = page_module.Page(
80 'http://google.com', page_set=story_set, 80 'http://google.com', page_set=story_set,
81 cache_temperature=cache_temperature.WARM, name='http://google.com') 81 cache_temperature=cache_temperature.WARM, name='http://google.com')
82 cache_temperature.EnsurePageCacheTemperature( 82 cache_temperature.EnsurePageCacheTemperature(
83 page, self._browser, previous_page) 83 page, self._browser, previous_page)
84 84
85 markers = self.traceMarkers() 85 markers = self.traceMarkers()
86 self.assertNotIn('telemetry.internal.warmCache.start', markers) 86 self.assertNotIn('telemetry.internal.warm_cache.start', markers)
87 87
88 @decorators.Enabled('has tabs') 88 @decorators.Enabled('has tabs')
89 @decorators.Disabled('chromeos') 89 @decorators.Disabled('chromeos')
90 def testEnsureWarmFromScratch(self): 90 def testEnsureWarmFromScratch(self):
91 with self.captureTrace(): 91 with self.captureTrace():
92 story_set = story.StorySet() 92 story_set = story.StorySet()
93 page = page_module.Page( 93 page = page_module.Page(
94 'http://google.com', page_set=story_set, 94 'http://google.com', page_set=story_set,
95 cache_temperature=cache_temperature.WARM, name='http://google.com') 95 cache_temperature=cache_temperature.WARM, name='http://google.com')
96 cache_temperature.EnsurePageCacheTemperature(page, self._browser) 96 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
97 97
98 markers = self.traceMarkers() 98 markers = self.traceMarkers()
99 self.assertIn('telemetry.internal.warmCache.start', markers) 99 self.assertIn('telemetry.internal.warm_cache.start', markers)
100 self.assertIn('telemetry.internal.warmCache.end', markers) 100 self.assertIn('telemetry.internal.warm_cache.end', markers)
OLDNEW
« no previous file with comments | « telemetry/telemetry/page/cache_temperature.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698