Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: rtc_tools/event_log_visualizer/analyzer.cc

Issue 3015753002: Don't append the bitrate twice to the outgoing bitrate plot in event_log_visualizer.
Patch Set: Created 3 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1012 matching lines...) Expand 10 before | Expand all | Expand 10 after
1023 result_series.points.emplace_back(x, y); 1023 result_series.points.emplace_back(x, y);
1024 } 1024 }
1025 } 1025 }
1026 1026
1027 if (show_detector_state) { 1027 if (show_detector_state) {
1028 plot->AppendIntervalSeries(std::move(overusing_series)); 1028 plot->AppendIntervalSeries(std::move(overusing_series));
1029 plot->AppendIntervalSeries(std::move(underusing_series)); 1029 plot->AppendIntervalSeries(std::move(underusing_series));
1030 plot->AppendIntervalSeries(std::move(normal_series)); 1030 plot->AppendIntervalSeries(std::move(normal_series));
1031 } 1031 }
1032 1032
1033 plot->AppendTimeSeries(std::move(bitrate_series));
1034 plot->AppendTimeSeries(std::move(loss_series)); 1033 plot->AppendTimeSeries(std::move(loss_series));
1035 plot->AppendTimeSeries(std::move(delay_series)); 1034 plot->AppendTimeSeries(std::move(delay_series));
1036 plot->AppendTimeSeries(std::move(created_series)); 1035 plot->AppendTimeSeries(std::move(created_series));
1037 plot->AppendTimeSeries(std::move(result_series)); 1036 plot->AppendTimeSeries(std::move(result_series));
1038 } 1037 }
1039 1038
1040 // Overlay the incoming REMB over the outgoing bitrate 1039 // Overlay the incoming REMB over the outgoing bitrate
1041 // and outgoing REMB over incoming bitrate. 1040 // and outgoing REMB over incoming bitrate.
1042 PacketDirection remb_direction = 1041 PacketDirection remb_direction =
1043 desired_direction == kOutgoingPacket ? kIncomingPacket : kOutgoingPacket; 1042 desired_direction == kOutgoingPacket ? kIncomingPacket : kOutgoingPacket;
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
1729 plot->AppendTimeSeries(std::move(series.second)); 1728 plot->AppendTimeSeries(std::move(series.second));
1730 } 1729 }
1731 1730
1732 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin); 1731 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
1733 plot->SetYAxis(min_y_axis, max_y_axis, "Relative delay (ms)", kBottomMargin, 1732 plot->SetYAxis(min_y_axis, max_y_axis, "Relative delay (ms)", kBottomMargin,
1734 kTopMargin); 1733 kTopMargin);
1735 plot->SetTitle("NetEq timing"); 1734 plot->SetTitle("NetEq timing");
1736 } 1735 }
1737 } // namespace plotting 1736 } // namespace plotting
1738 } // namespace webrtc 1737 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698