|
|
Created:
3 years, 3 months ago by nisse-webrtc Modified:
3 years, 3 months ago Reviewers:
perkj_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDrop reference to webrtc_overrides/.../task_queue.h
Since cl
https://chromium-review.googlesource.com/c/chromium/src/+/664807,
chromium no longer uses it. We need to stop referring to it from
webrtc, before it can be deleted in chromium.
BUG=webrtc:8166
Review-Url: https://codereview.webrtc.org/3015513002
Cr-Commit-Position: refs/heads/master@{#19901}
Committed: https://webrtc.googlesource.com/src/+/75dd6d4b9682131e1d92d4afda46241e0fdea33c
Patch Set 1 #Patch Set 2 : Rebase after The Great Move #Messages
Total messages: 19 (13 generated)
Moved to gerrit, https://webrtc-review.googlesource.com/c/src/+/1567
Message was sent while issue was closed.
Description was changed from ========== Drop reference to webrtc_overrides/.../task_queue.h Since cl https://chromium-review.googlesource.com/c/chromium/src/+/664807, chromium no longer uses it. We need to stop referring to it from webrtc, before it can be deleted in chromium. BUG=webrtc:8166 ========== to ========== Drop reference to webrtc_overrides/.../task_queue.h Since cl https://chromium-review.googlesource.com/c/chromium/src/+/664807, chromium no longer uses it. We need to stop referring to it from webrtc, before it can be deleted in chromium. BUG=webrtc:8166 ==========
nisse@webrtc.org changed reviewers: + perkj@webrtc.org
Moved cl back to rietveld, to be able to run fyi bots. Looks green so far.
lgtm
What do you think about the android bot failure? Do you want me to retry before landing, or can we be confident it's unrelated?
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21837)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505834729461520, "parent_rev": "4dc4e259ce5fca67b9bc6b7b6191126ffda91d58", "commit_rev": "75dd6d4b9682131e1d92d4afda46241e0fdea33c"}
Message was sent while issue was closed.
Description was changed from ========== Drop reference to webrtc_overrides/.../task_queue.h Since cl https://chromium-review.googlesource.com/c/chromium/src/+/664807, chromium no longer uses it. We need to stop referring to it from webrtc, before it can be deleted in chromium. BUG=webrtc:8166 ========== to ========== Drop reference to webrtc_overrides/.../task_queue.h Since cl https://chromium-review.googlesource.com/c/chromium/src/+/664807, chromium no longer uses it. We need to stop referring to it from webrtc, before it can be deleted in chromium. BUG=webrtc:8166 Review-Url: https://codereview.webrtc.org/3015513002 Cr-Commit-Position: refs/heads/master@{#19901} Committed: https://webrtc.googlesource.com/src/+/75dd6d4b9682131e1d92d4afda46241e0fdea33c ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://webrtc.googlesource.com/src/+/75dd6d4b9682131e1d92d4afda46241e0fdea33c |