Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 3015513002: Drop reference to webrtc_overrides/.../task_queue.h (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop reference to webrtc_overrides/.../task_queue.h Since cl https://chromium-review.googlesource.com/c/chromium/src/+/664807, chromium no longer uses it. We need to stop referring to it from webrtc, before it can be deleted in chromium. BUG=webrtc:8166 Review-Url: https://codereview.webrtc.org/3015513002 Cr-Commit-Position: refs/heads/master@{#19901} Committed: https://webrtc.googlesource.com/src/+/75dd6d4b9682131e1d92d4afda46241e0fdea33c

Patch Set 1 #

Patch Set 2 : Rebase after The Great Move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M rtc_base/BUILD.gn View 1 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
nisse-webrtc
Moved to gerrit, https://webrtc-review.googlesource.com/c/src/+/1567
3 years, 3 months ago (2017-09-15 07:21:53 UTC) #1
nisse-webrtc
Moved cl back to rietveld, to be able to run fyi bots. Looks green so ...
3 years, 3 months ago (2017-09-19 08:55:00 UTC) #4
perkj_webrtc
lgtm
3 years, 3 months ago (2017-09-19 09:38:10 UTC) #5
nisse-webrtc
What do you think about the android bot failure? Do you want me to retry ...
3 years, 3 months ago (2017-09-19 09:54:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015513002/20001
3 years, 3 months ago (2017-09-19 15:25:40 UTC) #16
commit-bot: I haz the power
3 years, 3 months ago (2017-09-19 15:28:07 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://webrtc.googlesource.com/src/+/75dd6d4b9682131e1d92d4afda46241e0fdea33c

Powered by Google App Engine
This is Rietveld 408576698