Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 3014563003: [Dashboard] Add M61 and M62 to speed releasing dashboard. (Closed)

Created:
3 years, 3 months ago by estevenson
Modified:
3 years, 3 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M dashboard/dashboard/speed_releasing.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
estevenson
ptal Ethan! I wasn't able to test this out locally (tried bin/dev_server with load_from_prod - ...
3 years, 3 months ago (2017-09-15 17:28:16 UTC) #2
eakuefner
lgtm, although it seems like you're also adding M60 -- can you please update your ...
3 years, 3 months ago (2017-09-19 00:22:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3014563003/1
3 years, 3 months ago (2017-09-19 15:07:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f158e5374fdf739c39edaad044db4e4d66ecfe15
3 years, 3 months ago (2017-09-19 15:38:56 UTC) #9
estevenson
3 years, 3 months ago (2017-09-19 15:40:27 UTC) #10
Message was sent while issue was closed.
On 2017/09/19 00:22:33, eakuefner wrote:
> lgtm, although it seems like you're also adding M60 -- can you please update
> your CL title/description?
> 
> Also, yeah, it's currently difficult to test dashboard changes locally. If
> you're ready for this to be picked up, please ping simonhatch@ and ask for the
> dashboard to be deployed. Then you'll be able to check this change in
production
> and follow up if necessary. This is a small change, though, so I expect
> everything should work fine.

Done. Thanks for the review! Will ping Simon soon.

Powered by Google App Engine
This is Rietveld 408576698