Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 3013903002: Slice video frame buffers before copying data from them into the encoder's input buffer (Closed)

Created:
1 year, 9 months ago by mellem
Modified:
1 year, 9 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Slice video frame buffers before copying data from them into the encoder's input buffer. This prevents the encoder from changing the state of video frame buffers that may still be in use by the caller. BUG=webrtc:8303

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java View 1 chunk +6 lines, -6 lines 2 comments Download

Messages

Total messages: 10 (6 generated)
mellem
1 year, 9 months ago (2017-09-28 00:27:42 UTC) #5
sakal
https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java File sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java (right): https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java#newcode545 sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java:545: buffer.put(i420.getDataY().slice()); Hmm, I think it is better to fix ...
1 year, 9 months ago (2017-09-28 07:43:54 UTC) #8
mellem
https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java File sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java (right): https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java#newcode545 sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java:545: buffer.put(i420.getDataY().slice()); Yes, I like that idea even better. I'll ...
1 year, 9 months ago (2017-09-28 17:02:39 UTC) #9
mellem
1 year, 9 months ago (2017-09-28 17:02:59 UTC) #10
On 2017/09/28 17:02:39, mellem wrote:
>
https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
> File sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java (right):
> 
>
https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
> sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java:545:
> buffer.put(i420.getDataY().slice());
> Yes, I like that idea even better.  I'll just abandon this cl and send you a
> follow-up through gerrit.

Follow-up:  https://webrtc-review.googlesource.com/c/src/+/4521

Powered by Google App Engine
This is Rietveld 408576698