Slice video frame buffers before copying data from them into the encoder's input buffer

Slice video frame buffers before copying data from them into the encoder's input buffer.

This prevents the encoder from changing the state of video frame buffers that may still be in use by the caller.

BUG=webrtc:8303

[mellem, 2017-09-28 00:26:24]

Description was changed from

==========
Slice video frame buffers before copying data from them into the encoder's input
buffer

BUG=
==========

to

==========
Slice video frame buffers before copying data from them into the encoder's input
buffer.

This prevents the encoder from changing the state of video frame buffers that
may still be in use by the caller.

BUG=webrtc:8303
==========

[mellem, 2017-09-28 00:26:24]

mellem@webrtc.org changed reviewers:
+ sakal@webrtc.org

[mellem, 2017-09-28 00:26:42]

The CQ bit was checked by mellem@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-28 00:26:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-28 00:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-28 00:51:24]

Dry run: This issue passed the CQ dry run.

[sakal, 2017-09-28 07:43:54]

https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
File sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java (right):

https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java:545:
buffer.put(i420.getDataY().slice());
Hmm, I think it is better to fix this at the VideoFrame.I420Buffer level, i.e.
call buffer.slice() before returning from getDataY/U/V(). This makes it clearer
that the state of the buffer object is immutable.

[mellem, 2017-09-28 17:02:39]

https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
File sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java (right):

https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java:545:
buffer.put(i420.getDataY().slice());
Yes, I like that idea even better.  I'll just abandon this cl and send you a
follow-up through gerrit.

[mellem, 2017-09-28 17:02:59]

On 2017/09/28 17:02:39, mellem wrote:
>
https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
> File sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java (right):
> 
>
https://codereview.webrtc.org/3013903002/diff/1/sdk/android/src/java/org/webr...
> sdk/android/src/java/org/webrtc/HardwareVideoEncoder.java:545:
> buffer.put(i420.getDataY().slice());
> Yes, I like that idea even better.  I'll just abandon this cl and send you a
> follow-up through gerrit.

Follow-up:  https://webrtc-review.googlesource.com/c/src/+/4521