catapult_build/js_checks.py - Issue 3012573002: Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: catapult_build/js_checks.py

Issue 3012573002: Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished (Closed)

Patch Set: fix presubmit error Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: catapult_build/js_checks.py

diff --git a/catapult_build/js_checks.py b/catapult_build/js_checks.py

index 78cc745ebd8c0a9d391d4f7b6b80392c3d74fce2..f182b813cb3ed37f8d3e341197b99eff6260ba78 100644

--- a/catapult_build/js_checks.py

+++ b/catapult_build/js_checks.py

@@ -98,7 +98,7 @@ def _FirstStatement(contents):

stripped_contents = strip_js_comments.StripJSComments(contents).strip()

matches = re.match('^(.*?);', stripped_contents, re.DOTALL)

if not matches:

- return ''

+ return contents

return matches.group(1).strip()